* [PATCH] powerpc/32s: fix initial setup of segment registers on secondary CPU
@ 2019-06-11 15:47 Christophe Leroy
2019-06-11 16:46 ` Christophe Leroy
2019-06-16 12:23 ` Michael Ellerman
0 siblings, 2 replies; 5+ messages in thread
From: Christophe Leroy @ 2019-06-11 15:47 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
erhard_f
Cc: linuxppc-dev, linux-kernel
The patch referenced below moved the loading of segment registers
out of load_up_mmu() in order to do it earlier in the boot sequence.
However, the secondary CPU still needs it to be done when loading up
the MMU.
Reported-by: Erhard F. <erhard_f@mailbox.org>
Fixes: 215b823707ce ("powerpc/32s: set up an early static hash table for KASAN")
Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
---
arch/powerpc/kernel/head_32.S | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kernel/head_32.S b/arch/powerpc/kernel/head_32.S
index 1d5f1bd0dacd..f255e22184b4 100644
--- a/arch/powerpc/kernel/head_32.S
+++ b/arch/powerpc/kernel/head_32.S
@@ -752,6 +752,7 @@ __secondary_start:
stw r0,0(r3)
/* load up the MMU */
+ bl load_segment_registers
bl load_up_mmu
/* ptr to phys current thread */
--
2.13.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] powerpc/32s: fix initial setup of segment registers on secondary CPU
2019-06-11 15:47 [PATCH] powerpc/32s: fix initial setup of segment registers on secondary CPU Christophe Leroy
@ 2019-06-11 16:46 ` Christophe Leroy
2019-06-18 12:31 ` Michael Ellerman
2019-06-16 12:23 ` Michael Ellerman
1 sibling, 1 reply; 5+ messages in thread
From: Christophe Leroy @ 2019-06-11 16:46 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
erhard_f
Cc: linuxppc-dev, linux-kernel
Le 11/06/2019 à 17:47, Christophe Leroy a écrit :
> The patch referenced below moved the loading of segment registers
> out of load_up_mmu() in order to do it earlier in the boot sequence.
> However, the secondary CPU still needs it to be done when loading up
> the MMU.
>
> Reported-by: Erhard F. <erhard_f@mailbox.org>
> Fixes: 215b823707ce ("powerpc/32s: set up an early static hash table for KASAN")
Cc: stable@vger.kernel.org
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
> arch/powerpc/kernel/head_32.S | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/kernel/head_32.S b/arch/powerpc/kernel/head_32.S
> index 1d5f1bd0dacd..f255e22184b4 100644
> --- a/arch/powerpc/kernel/head_32.S
> +++ b/arch/powerpc/kernel/head_32.S
> @@ -752,6 +752,7 @@ __secondary_start:
> stw r0,0(r3)
>
> /* load up the MMU */
> + bl load_segment_registers
> bl load_up_mmu
>
> /* ptr to phys current thread */
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] powerpc/32s: fix initial setup of segment registers on secondary CPU
2019-06-11 16:46 ` Christophe Leroy
@ 2019-06-18 12:31 ` Michael Ellerman
2019-06-18 12:44 ` Christophe Leroy
0 siblings, 1 reply; 5+ messages in thread
From: Michael Ellerman @ 2019-06-18 12:31 UTC (permalink / raw)
To: Christophe Leroy, Benjamin Herrenschmidt, Paul Mackerras,
erhard_f
Cc: linuxppc-dev, linux-kernel
Christophe Leroy <christophe.leroy@c-s.fr> writes:
> Le 11/06/2019 à 17:47, Christophe Leroy a écrit :
>> The patch referenced below moved the loading of segment registers
>> out of load_up_mmu() in order to do it earlier in the boot sequence.
>> However, the secondary CPU still needs it to be done when loading up
>> the MMU.
>>
>> Reported-by: Erhard F. <erhard_f@mailbox.org>
>> Fixes: 215b823707ce ("powerpc/32s: set up an early static hash table for KASAN")
>
> Cc: stable@vger.kernel.org
Sorry patchwork didn't pick that up and I missed it. The AUTOSEL bot
will probably pick it up anyway though.
cheers
>> diff --git a/arch/powerpc/kernel/head_32.S b/arch/powerpc/kernel/head_32.S
>> index 1d5f1bd0dacd..f255e22184b4 100644
>> --- a/arch/powerpc/kernel/head_32.S
>> +++ b/arch/powerpc/kernel/head_32.S
>> @@ -752,6 +752,7 @@ __secondary_start:
>> stw r0,0(r3)
>>
>> /* load up the MMU */
>> + bl load_segment_registers
>> bl load_up_mmu
>>
>> /* ptr to phys current thread */
>>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] powerpc/32s: fix initial setup of segment registers on secondary CPU
2019-06-18 12:31 ` Michael Ellerman
@ 2019-06-18 12:44 ` Christophe Leroy
0 siblings, 0 replies; 5+ messages in thread
From: Christophe Leroy @ 2019-06-18 12:44 UTC (permalink / raw)
To: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
erhard_f
Cc: linuxppc-dev, linux-kernel
Le 18/06/2019 à 14:31, Michael Ellerman a écrit :
> Christophe Leroy <christophe.leroy@c-s.fr> writes:
>> Le 11/06/2019 à 17:47, Christophe Leroy a écrit :
>>> The patch referenced below moved the loading of segment registers
>>> out of load_up_mmu() in order to do it earlier in the boot sequence.
>>> However, the secondary CPU still needs it to be done when loading up
>>> the MMU.
>>>
>>> Reported-by: Erhard F. <erhard_f@mailbox.org>
>>> Fixes: 215b823707ce ("powerpc/32s: set up an early static hash table for KASAN")
>>
>> Cc: stable@vger.kernel.org
>
> Sorry patchwork didn't pick that up and I missed it. The AUTOSEL bot
> will probably pick it up anyway though.
Don't worry, this was unneeded because we added KASAN in 5.2.
My mistake.
Christophe
>
> cheers
>
>>> diff --git a/arch/powerpc/kernel/head_32.S b/arch/powerpc/kernel/head_32.S
>>> index 1d5f1bd0dacd..f255e22184b4 100644
>>> --- a/arch/powerpc/kernel/head_32.S
>>> +++ b/arch/powerpc/kernel/head_32.S
>>> @@ -752,6 +752,7 @@ __secondary_start:
>>> stw r0,0(r3)
>>>
>>> /* load up the MMU */
>>> + bl load_segment_registers
>>> bl load_up_mmu
>>>
>>> /* ptr to phys current thread */
>>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/32s: fix initial setup of segment registers on secondary CPU
2019-06-11 15:47 [PATCH] powerpc/32s: fix initial setup of segment registers on secondary CPU Christophe Leroy
2019-06-11 16:46 ` Christophe Leroy
@ 2019-06-16 12:23 ` Michael Ellerman
1 sibling, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2019-06-16 12:23 UTC (permalink / raw)
To: Christophe Leroy, Benjamin Herrenschmidt, Paul Mackerras,
erhard_f
Cc: linuxppc-dev, linux-kernel
On Tue, 2019-06-11 at 15:47:20 UTC, Christophe Leroy wrote:
> The patch referenced below moved the loading of segment registers
> out of load_up_mmu() in order to do it earlier in the boot sequence.
> However, the secondary CPU still needs it to be done when loading up
> the MMU.
>
> Reported-by: Erhard F. <erhard_f@mailbox.org>
> Fixes: 215b823707ce ("powerpc/32s: set up an early static hash table for KASAN")
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/b7f8b440f3001cc1775c028f0a783786113c2ae3
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-18 12:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-11 15:47 [PATCH] powerpc/32s: fix initial setup of segment registers on secondary CPU Christophe Leroy
2019-06-11 16:46 ` Christophe Leroy
2019-06-18 12:31 ` Michael Ellerman
2019-06-18 12:44 ` Christophe Leroy
2019-06-16 12:23 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).