From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 391FCC5B57E for ; Sun, 30 Jun 2019 08:41:09 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD7762070D for ; Sun, 30 Jun 2019 08:41:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD7762070D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45c3r23QPNzDqHd for ; Sun, 30 Jun 2019 18:41:06 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45c3lh5fG3zDqLc for ; Sun, 30 Jun 2019 18:37:20 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: by ozlabs.org (Postfix, from userid 1034) id 45c3lh4zYrz9sCJ; Sun, 30 Jun 2019 18:37:20 +1000 (AEST) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 348ea30f51fc63ce3c7fd7dba6043e8e3ee0ef34 X-Patchwork-Hint: ignore In-Reply-To: <20190528232801.7413-1-nathanl@linux.ibm.com> To: Nathan Lynch , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Subject: Re: [PATCH] powerpc/pseries: avoid blocking in irq when queuing hotplug events Message-Id: <45c3lh4zYrz9sCJ@ozlabs.org> Date: Sun, 30 Jun 2019 18:37:20 +1000 (AEST) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, 2019-05-28 at 23:28:01 UTC, Nathan Lynch wrote: > A couple of bugs in queue_hotplug_event(): > > 1. Unchecked kmalloc result which could lead to an oops. > 2. Use of GFP_KERNEL allocations in interrupt context (this code's > only caller is ras_hotplug_interrupt()). > > Use kmemdup to avoid open-coding the allocation+copy and check for > failure; use GFP_ATOMIC for both allocations. > > Ultimately it probably would be better to avoid or reduce allocations > in this path if possible. > > Signed-off-by: Nathan Lynch Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/348ea30f51fc63ce3c7fd7dba6043e8e3ee0ef34 cheers