* [PATCH] powerpc/64s: Fix misleading SPR and timebase information
@ 2019-05-29 9:21 Shaokun Zhang
2019-06-12 9:54 ` Zhangshaokun
2019-06-30 8:37 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Shaokun Zhang @ 2019-05-29 9:21 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Shaokun Zhang, Nicholas Piggin
pr_info shows SPR and timebase as a decimal value with a '0x'
prefix, which is somewhat misleading.
Fix it to print hexadecimal, as was intended.
Fixes: 10d91611f426 ("powerpc/64s: Reimplement book3s idle code in C")
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
---
arch/powerpc/platforms/powernv/idle.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/idle.c b/arch/powerpc/platforms/powernv/idle.c
index c9133f7908ca..77f2e0a4ee37 100644
--- a/arch/powerpc/platforms/powernv/idle.c
+++ b/arch/powerpc/platforms/powernv/idle.c
@@ -1159,10 +1159,10 @@ static void __init pnv_power9_idle_init(void)
pnv_deepest_stop_psscr_mask);
}
- pr_info("cpuidle-powernv: First stop level that may lose SPRs = 0x%lld\n",
+ pr_info("cpuidle-powernv: First stop level that may lose SPRs = 0x%llx\n",
pnv_first_spr_loss_level);
- pr_info("cpuidle-powernv: First stop level that may lose timebase = 0x%lld\n",
+ pr_info("cpuidle-powernv: First stop level that may lose timebase = 0x%llx\n",
pnv_first_tb_loss_level);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/64s: Fix misleading SPR and timebase information
2019-05-29 9:21 [PATCH] powerpc/64s: Fix misleading SPR and timebase information Shaokun Zhang
@ 2019-06-12 9:54 ` Zhangshaokun
2019-06-30 8:37 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Zhangshaokun @ 2019-06-12 9:54 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Nicholas Piggin
Hi Michael,
A gentle ping.
On 2019/5/29 17:21, Shaokun Zhang wrote:
> pr_info shows SPR and timebase as a decimal value with a '0x'
> prefix, which is somewhat misleading.
>
> Fix it to print hexadecimal, as was intended.
>
> Fixes: 10d91611f426 ("powerpc/64s: Reimplement book3s idle code in C")
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Nicholas Piggin <npiggin@gmail.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
> arch/powerpc/platforms/powernv/idle.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powernv/idle.c b/arch/powerpc/platforms/powernv/idle.c
> index c9133f7908ca..77f2e0a4ee37 100644
> --- a/arch/powerpc/platforms/powernv/idle.c
> +++ b/arch/powerpc/platforms/powernv/idle.c
> @@ -1159,10 +1159,10 @@ static void __init pnv_power9_idle_init(void)
> pnv_deepest_stop_psscr_mask);
> }
>
> - pr_info("cpuidle-powernv: First stop level that may lose SPRs = 0x%lld\n",
> + pr_info("cpuidle-powernv: First stop level that may lose SPRs = 0x%llx\n",
> pnv_first_spr_loss_level);
>
> - pr_info("cpuidle-powernv: First stop level that may lose timebase = 0x%lld\n",
> + pr_info("cpuidle-powernv: First stop level that may lose timebase = 0x%llx\n",
> pnv_first_tb_loss_level);
> }
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/64s: Fix misleading SPR and timebase information
2019-05-29 9:21 [PATCH] powerpc/64s: Fix misleading SPR and timebase information Shaokun Zhang
2019-06-12 9:54 ` Zhangshaokun
@ 2019-06-30 8:37 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2019-06-30 8:37 UTC (permalink / raw)
To: Shaokun Zhang, linuxppc-dev; +Cc: Shaokun Zhang, Nicholas Piggin
On Wed, 2019-05-29 at 09:21:51 UTC, Shaokun Zhang wrote:
> pr_info shows SPR and timebase as a decimal value with a '0x'
> prefix, which is somewhat misleading.
>
> Fix it to print hexadecimal, as was intended.
>
> Fixes: 10d91611f426 ("powerpc/64s: Reimplement book3s idle code in C")
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Nicholas Piggin <npiggin@gmail.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/87997471c597d0594dc8c9346ecaafab83798cf3
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-30 8:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-29 9:21 [PATCH] powerpc/64s: Fix misleading SPR and timebase information Shaokun Zhang
2019-06-12 9:54 ` Zhangshaokun
2019-06-30 8:37 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).