From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F13D4C7618A for ; Mon, 15 Jul 2019 05:28:29 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96CD520644 for ; Mon, 15 Jul 2019 05:28:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96CD520644 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45nBrq3mWSzDqS4 for ; Mon, 15 Jul 2019 15:28:27 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45nBmW4ldNzDqK1 for ; Mon, 15 Jul 2019 15:24:43 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: by ozlabs.org (Postfix, from userid 1034) id 45nBmW3RrRz9sNH; Mon, 15 Jul 2019 15:24:43 +1000 (AEST) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 33439620680be5225c1b8806579a291e0d761ca0 In-Reply-To: <20190710150517.27114-1-oohall@gmail.com> To: Oliver O'Halloran , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Subject: Re: [PATCH] powerpc/eeh: Handle hugepages in ioremap space Message-Id: <45nBmW3RrRz9sNH@ozlabs.org> Date: Mon, 15 Jul 2019 15:24:43 +1000 (AEST) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sachin Sant , Oliver O'Halloran , Nicholas Piggin Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, 2019-07-10 at 15:05:17 UTC, Oliver O'Halloran wrote: > In commit 4a7b06c157a2 ("powerpc/eeh: Handle hugepages in ioremap > space") support for using hugepages in the vmalloc and ioremap areas was > enabled for radix. Unfortunately this broke EEH MMIO error checking. > > Detection works by inserting a hook which checks the results of the > ioreadXX() set of functions. When a read returns a 0xFFs response we > need to check for an error which we do by mapping the (virtual) MMIO > address back to a physical address, then mapping physical address to a > PCI device via an interval tree. > > When translating virt -> phys we currently assume the ioremap space is > only populated by PAGE_SIZE mappings. If a hugepage mapping is found we > emit a WARN_ON(), but otherwise handles the check as though a normal > page was found. In pathalogical cases such as copying a buffer > containing a lot of 0xFFs from BAR memory this can result in the system > not booting because it's too busy printing WARN_ON()s. > > There's no real reason to assume huge pages can't be present and we're > prefectly capable of handling them, so do that. > > Cc: Nicholas Piggin > Fixes: 4a7b06c157a2 ("powerpc/eeh: Handle hugepages in ioremap space") > Reported-by: Sachin Sant > Signed-off-by: Oliver O'Halloran > Tested-by: Sachin Sant Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/33439620680be5225c1b8806579a291e0d761ca0 cheers