From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14D4AC76196 for ; Mon, 22 Jul 2019 02:52:55 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB81C21953 for ; Mon, 22 Jul 2019 02:52:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB81C21953 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45sR443tqqzDqGQ for ; Mon, 22 Jul 2019 12:52:52 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45sQyl3srJzDqM5 for ; Mon, 22 Jul 2019 12:48:15 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: by ozlabs.org (Postfix, from userid 1034) id 45sQyl0Vglz9sBZ; Mon, 22 Jul 2019 12:48:15 +1000 (AEST) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: b4fc36e60f25cf22bf8b7b015a701015740c3743 In-Reply-To: <20190717235437.12908-1-shawn@anastas.io> To: Shawn Anastasio , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Subject: Re: [PATCH] powerpc/dma: Fix invalid DMA mmap behavior Message-Id: <45sQyl0Vglz9sBZ@ozlabs.org> Date: Mon, 22 Jul 2019 12:48:15 +1000 (AEST) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aik@ozlabs.ru, sbobroff@linux.ibm.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, 2019-07-17 at 23:54:37 UTC, Shawn Anastasio wrote: > The refactor of powerpc DMA functions in commit 6666cc17d780 > ("powerpc/dma: remove dma_nommu_mmap_coherent") incorrectly > changes the way DMA mappings are handled on powerpc. > Since this change, all mapped pages are marked as cache-inhibited > through the default implementation of arch_dma_mmap_pgprot. > This differs from the previous behavior of only marking pages > in noncoherent mappings as cache-inhibited and has resulted in > sporadic system crashes in certain hardware configurations and > workloads (see Bugzilla). > > This commit restores the previous correct behavior by providing > an implementation of arch_dma_mmap_pgprot that only marks > pages in noncoherent mappings as cache-inhibited. As this behavior > should be universal for all powerpc platforms a new file, > dma-generic.c, was created to store it. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204145 > Fixes: 6666cc17d780 ("powerpc/dma: remove dma_nommu_mmap_coherent") > Signed-off-by: Shawn Anastasio > Reviewed-by: Alexey Kardashevskiy > Reviewed-by: Christoph Hellwig Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/b4fc36e60f25cf22bf8b7b015a701015740c3743 cheers