* [PATCH] powerpc/kvm: Fall through switch case explicitly
@ 2019-07-29 5:55 Santosh Sivaraj
2019-07-29 8:16 ` Stephen Rothwell
2019-07-30 22:50 ` Michael Ellerman
0 siblings, 2 replies; 9+ messages in thread
From: Santosh Sivaraj @ 2019-07-29 5:55 UTC (permalink / raw)
To: linuxppc-dev
Implicit fallthrough warning was enabled globally which broke
the build. Make it explicit with a `fall through` comment.
Signed-off-by: Santosh Sivaraj <santosh@fossix.org>
---
arch/powerpc/kvm/book3s_32_mmu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kvm/book3s_32_mmu.c b/arch/powerpc/kvm/book3s_32_mmu.c
index 653936177857..18f244aad7aa 100644
--- a/arch/powerpc/kvm/book3s_32_mmu.c
+++ b/arch/powerpc/kvm/book3s_32_mmu.c
@@ -239,6 +239,7 @@ static int kvmppc_mmu_book3s_32_xlate_pte(struct kvm_vcpu *vcpu, gva_t eaddr,
case 2:
case 6:
pte->may_write = true;
+ /* fall through */
case 3:
case 5:
case 7:
--
2.20.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] powerpc/kvm: Fall through switch case explicitly
2019-07-29 5:55 [PATCH] powerpc/kvm: Fall through switch case explicitly Santosh Sivaraj
@ 2019-07-29 8:16 ` Stephen Rothwell
2019-07-29 23:45 ` Gustavo A. R. Silva
2019-07-30 22:50 ` Michael Ellerman
1 sibling, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2019-07-29 8:16 UTC (permalink / raw)
To: Santosh Sivaraj; +Cc: linuxppc-dev, Kees Cook, Gustavo A. R. Silva
[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]
Hi Santosh,
On Mon, 29 Jul 2019 11:25:36 +0530 Santosh Sivaraj <santosh@fossix.org> wrote:
>
> Implicit fallthrough warning was enabled globally which broke
> the build. Make it explicit with a `fall through` comment.
>
> Signed-off-by: Santosh Sivaraj <santosh@fossix.org>
> ---
> arch/powerpc/kvm/book3s_32_mmu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/kvm/book3s_32_mmu.c b/arch/powerpc/kvm/book3s_32_mmu.c
> index 653936177857..18f244aad7aa 100644
> --- a/arch/powerpc/kvm/book3s_32_mmu.c
> +++ b/arch/powerpc/kvm/book3s_32_mmu.c
> @@ -239,6 +239,7 @@ static int kvmppc_mmu_book3s_32_xlate_pte(struct kvm_vcpu *vcpu, gva_t eaddr,
> case 2:
> case 6:
> pte->may_write = true;
> + /* fall through */
> case 3:
> case 5:
> case 7:
> --
> 2.20.1
>
Thanks
Reviewed-by: Stephen Rothwell <sfr@canb.auug.org.au>
This only shows up as a warning in a powerpc allyesconfig build.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] powerpc/kvm: Fall through switch case explicitly
2019-07-29 8:16 ` Stephen Rothwell
@ 2019-07-29 23:45 ` Gustavo A. R. Silva
2019-07-30 3:18 ` Stephen Rothwell
0 siblings, 1 reply; 9+ messages in thread
From: Gustavo A. R. Silva @ 2019-07-29 23:45 UTC (permalink / raw)
To: Stephen Rothwell, Santosh Sivaraj; +Cc: linuxppc-dev, Kees Cook
On 7/29/19 3:16 AM, Stephen Rothwell wrote:
> Hi Santosh,
>
> On Mon, 29 Jul 2019 11:25:36 +0530 Santosh Sivaraj <santosh@fossix.org> wrote:
>>
>> Implicit fallthrough warning was enabled globally which broke
>> the build. Make it explicit with a `fall through` comment.
>>
>> Signed-off-by: Santosh Sivaraj <santosh@fossix.org>
Reviewed-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Thanks!
--
Gustavo
>> ---
>> arch/powerpc/kvm/book3s_32_mmu.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/powerpc/kvm/book3s_32_mmu.c b/arch/powerpc/kvm/book3s_32_mmu.c
>> index 653936177857..18f244aad7aa 100644
>> --- a/arch/powerpc/kvm/book3s_32_mmu.c
>> +++ b/arch/powerpc/kvm/book3s_32_mmu.c
>> @@ -239,6 +239,7 @@ static int kvmppc_mmu_book3s_32_xlate_pte(struct kvm_vcpu *vcpu, gva_t eaddr,
>> case 2:
>> case 6:
>> pte->may_write = true;
>> + /* fall through */
>> case 3:
>> case 5:
>> case 7:
>> --
>> 2.20.1
>>
>
> Thanks
>
> Reviewed-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> This only shows up as a warning in a powerpc allyesconfig build.
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] powerpc/kvm: Fall through switch case explicitly
2019-07-29 23:45 ` Gustavo A. R. Silva
@ 2019-07-30 3:18 ` Stephen Rothwell
2019-07-30 3:30 ` Gustavo A. R. Silva
0 siblings, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2019-07-30 3:18 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Santosh Sivaraj, linuxppc-dev, Kees Cook
[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]
Hi all,
On Mon, 29 Jul 2019 18:45:40 -0500 "Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
>
> On 7/29/19 3:16 AM, Stephen Rothwell wrote:
> >
> > On Mon, 29 Jul 2019 11:25:36 +0530 Santosh Sivaraj <santosh@fossix.org> wrote:
> >>
> >> Implicit fallthrough warning was enabled globally which broke
> >> the build. Make it explicit with a `fall through` comment.
> >>
> >> Signed-off-by: Santosh Sivaraj <santosh@fossix.org>
>
> Reviewed-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Thanks!
> --
> Gustavo
>
> >> ---
> >> arch/powerpc/kvm/book3s_32_mmu.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/arch/powerpc/kvm/book3s_32_mmu.c b/arch/powerpc/kvm/book3s_32_mmu.c
> >> index 653936177857..18f244aad7aa 100644
> >> --- a/arch/powerpc/kvm/book3s_32_mmu.c
> >> +++ b/arch/powerpc/kvm/book3s_32_mmu.c
> >> @@ -239,6 +239,7 @@ static int kvmppc_mmu_book3s_32_xlate_pte(struct kvm_vcpu *vcpu, gva_t eaddr,
> >> case 2:
> >> case 6:
> >> pte->may_write = true;
> >> + /* fall through */
> >> case 3:
> >> case 5:
> >> case 7:
> >> --
> >> 2.20.1
> >>
> >
> > Thanks
> >
> > Reviewed-by: Stephen Rothwell <sfr@canb.auug.org.au>
> >
> > This only shows up as a warning in a powerpc allyesconfig build.
> >
I will apply this to linux-next today (and keep it until it turns up in
some other tree).
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] powerpc/kvm: Fall through switch case explicitly
2019-07-30 3:18 ` Stephen Rothwell
@ 2019-07-30 3:30 ` Gustavo A. R. Silva
2019-07-30 3:50 ` Stephen Rothwell
0 siblings, 1 reply; 9+ messages in thread
From: Gustavo A. R. Silva @ 2019-07-30 3:30 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Santosh Sivaraj, linuxppc-dev, Kees Cook
Hi Stephen,
On 7/29/19 10:18 PM, Stephen Rothwell wrote:
> Hi all,
>
> On Mon, 29 Jul 2019 18:45:40 -0500 "Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
>>
>> On 7/29/19 3:16 AM, Stephen Rothwell wrote:
>>>
>>> On Mon, 29 Jul 2019 11:25:36 +0530 Santosh Sivaraj <santosh@fossix.org> wrote:
>>>>
>>>> Implicit fallthrough warning was enabled globally which broke
>>>> the build. Make it explicit with a `fall through` comment.
>>>>
>>>> Signed-off-by: Santosh Sivaraj <santosh@fossix.org>
>>
>> Reviewed-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>>
>> Thanks!
>> --
>> Gustavo
>>
>>>> ---
>>>> arch/powerpc/kvm/book3s_32_mmu.c | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/arch/powerpc/kvm/book3s_32_mmu.c b/arch/powerpc/kvm/book3s_32_mmu.c
>>>> index 653936177857..18f244aad7aa 100644
>>>> --- a/arch/powerpc/kvm/book3s_32_mmu.c
>>>> +++ b/arch/powerpc/kvm/book3s_32_mmu.c
>>>> @@ -239,6 +239,7 @@ static int kvmppc_mmu_book3s_32_xlate_pte(struct kvm_vcpu *vcpu, gva_t eaddr,
>>>> case 2:
>>>> case 6:
>>>> pte->may_write = true;
>>>> + /* fall through */
>>>> case 3:
>>>> case 5:
>>>> case 7:
>>>> --
>>>> 2.20.1
>>>>
>>>
>>> Thanks
>>>
>>> Reviewed-by: Stephen Rothwell <sfr@canb.auug.org.au>
>>>
>>> This only shows up as a warning in a powerpc allyesconfig build.
>>>
>
> I will apply this to linux-next today (and keep it until it turns up in
> some other tree).
>
If no one takes it by tomorrow, I'll take it in my tree.
Thanks!
--
Gustavo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] powerpc/kvm: Fall through switch case explicitly
2019-07-30 3:30 ` Gustavo A. R. Silva
@ 2019-07-30 3:50 ` Stephen Rothwell
2019-07-30 3:57 ` Gustavo A. R. Silva
0 siblings, 1 reply; 9+ messages in thread
From: Stephen Rothwell @ 2019-07-30 3:50 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Santosh Sivaraj, linuxppc-dev, Kees Cook
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
Hi Gustavo,
On Mon, 29 Jul 2019 22:30:34 -0500 "Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
>
> If no one takes it by tomorrow, I'll take it in my tree.
I am assuming that Michael Ellerman will take it into his fixes tree
and send it to Lunis fairly soon as it actually breaks some powerpc
builds.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] powerpc/kvm: Fall through switch case explicitly
2019-07-30 3:50 ` Stephen Rothwell
@ 2019-07-30 3:57 ` Gustavo A. R. Silva
2019-07-30 4:34 ` Stephen Rothwell
0 siblings, 1 reply; 9+ messages in thread
From: Gustavo A. R. Silva @ 2019-07-30 3:57 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Santosh Sivaraj, linuxppc-dev, Kees Cook
On 7/29/19 10:50 PM, Stephen Rothwell wrote:
> Hi Gustavo,
>
> On Mon, 29 Jul 2019 22:30:34 -0500 "Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
>>
>> If no one takes it by tomorrow, I'll take it in my tree.
>
> I am assuming that Michael Ellerman will take it into his fixes tree
> and send it to Lunis fairly soon as it actually breaks some powerpc
> builds.
>
Yeah. It seems that now that -Wimplicit-fallthrough has been globally enabled,
that's the case for all of these patches.
Anyway, I can always take them in my tree if needed.
Thanks
--
Gustavo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] powerpc/kvm: Fall through switch case explicitly
2019-07-30 3:57 ` Gustavo A. R. Silva
@ 2019-07-30 4:34 ` Stephen Rothwell
0 siblings, 0 replies; 9+ messages in thread
From: Stephen Rothwell @ 2019-07-30 4:34 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Santosh Sivaraj, linuxppc-dev, Kees Cook
[-- Attachment #1: Type: text/plain, Size: 609 bytes --]
Hi Gustavo,
On Mon, 29 Jul 2019 22:57:05 -0500 "Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
>
> On 7/29/19 10:50 PM, Stephen Rothwell wrote:
> >
> > I am assuming that Michael Ellerman will take it into his fixes tree
> > and send it to Lunis fairly soon as it actually breaks some powerpc
> > builds.
>
> Yeah. It seems that now that -Wimplicit-fallthrough has been globally enabled,
> that's the case for all of these patches.
Only some of them cause failures (as opposed to warnings) .. in this
case because arch/powerpc is built with -Werror.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] powerpc/kvm: Fall through switch case explicitly
2019-07-29 5:55 [PATCH] powerpc/kvm: Fall through switch case explicitly Santosh Sivaraj
2019-07-29 8:16 ` Stephen Rothwell
@ 2019-07-30 22:50 ` Michael Ellerman
1 sibling, 0 replies; 9+ messages in thread
From: Michael Ellerman @ 2019-07-30 22:50 UTC (permalink / raw)
To: Santosh Sivaraj, linuxppc-dev
On Mon, 2019-07-29 at 05:55:36 UTC, Santosh Sivaraj wrote:
> Implicit fallthrough warning was enabled globally which broke
> the build. Make it explicit with a `fall through` comment.
>
> Signed-off-by: Santosh Sivaraj <santosh@fossix.org>
> Reviewed-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Reviewed-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/705d0abbcc7adf04743d04ea8754acbcdf21c326
cheers
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-07-30 22:52 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-29 5:55 [PATCH] powerpc/kvm: Fall through switch case explicitly Santosh Sivaraj
2019-07-29 8:16 ` Stephen Rothwell
2019-07-29 23:45 ` Gustavo A. R. Silva
2019-07-30 3:18 ` Stephen Rothwell
2019-07-30 3:30 ` Gustavo A. R. Silva
2019-07-30 3:50 ` Stephen Rothwell
2019-07-30 3:57 ` Gustavo A. R. Silva
2019-07-30 4:34 ` Stephen Rothwell
2019-07-30 22:50 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).