[PATCH] Fix MPC8548CDS rebooting procedure

[PATCH] Fix MPC8548CDS rebooting procedure

[Haruki Dai-r35557]

This patch fixes the MPC8548 CDS rebooting procedure.
Without this patche, issuing reboot from shell doesn't reboot the
machine.=20

Signed-off-by: Dai Haruki <dai.haruki@freescale.com>

---

 arch/ppc/syslib/ppc85xx_setup.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

8f095006923385c3546165b0e10d73d3e057c120
diff --git a/arch/ppc/syslib/ppc85xx_setup.c
b/arch/ppc/syslib/ppc85xx_setup.c
index e4dda43..45b1b2b 100644
--- a/arch/ppc/syslib/ppc85xx_setup.c
+++ b/arch/ppc/syslib/ppc85xx_setup.c
@@ -115,6 +115,11 @@ mpc85xx_early_serial_map(void)
 void
 mpc85xx_restart(char *cmd)
 {
+#ifdef CONFIG_MPC8548
+	volatile unsigned int *rstcr;
+	u32 *pMem =3D (u32*) ioremap((BOARD_CCSRBAR + 0xe00b0),0x100);
+	*pMem =3D 0x2; /* Set HRESET_REQ flag */
+#endif
 	local_irq_disable();
 	abort();
 }
--=20
1.2.4

Re: [PATCH] Fix MPC8548CDS rebooting procedure

[Kumar Gala]

On Mar 8, 2006, at 11:22 AM, Haruki Dai-r35557 wrote:

> This patch fixes the MPC8548 CDS rebooting procedure.
> Without this patche, issuing reboot from shell doesn't reboot the
> machine.
>
> Signed-off-by: Dai Haruki <dai.haruki@freescale.com>

Dai, I'm avoid taking patches for 85xx that effect new  
functionality.  If you want change this to work with arch/powerpc and  
make it a run time check for 8548.

- kumar

> ---
>
>  arch/ppc/syslib/ppc85xx_setup.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
>
> 8f095006923385c3546165b0e10d73d3e057c120
> diff --git a/arch/ppc/syslib/ppc85xx_setup.c
> b/arch/ppc/syslib/ppc85xx_setup.c
> index e4dda43..45b1b2b 100644
> --- a/arch/ppc/syslib/ppc85xx_setup.c
> +++ b/arch/ppc/syslib/ppc85xx_setup.c
> @@ -115,6 +115,11 @@ mpc85xx_early_serial_map(void)
>  void
>  mpc85xx_restart(char *cmd)
>  {
> +#ifdef CONFIG_MPC8548
> +	volatile unsigned int *rstcr;
> +	u32 *pMem = (u32*) ioremap((BOARD_CCSRBAR + 0xe00b0),0x100);
> +	*pMem = 0x2; /* Set HRESET_REQ flag */
> +#endif
>  	local_irq_disable();
>  	abort();
>  }
> -- 
> 1.2.4
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

RE: [PATCH] Fix MPC8548CDS rebooting procedure

[Haruki Dai-r35557]

> -----Original Message-----
> From: Kumar Gala [mailto:galak@kernel.crashing.org]=20
> Sent: Wednesday, March 08, 2006 12:33 PM
> To: Haruki Dai-r35557
> Cc: linuxppc-dev@ozlabs.org
> Subject: Re: [PATCH] Fix MPC8548CDS rebooting procedure
>=20
>=20
> On Mar 8, 2006, at 11:22 AM, Haruki Dai-r35557 wrote:
>=20
> > This patch fixes the MPC8548 CDS rebooting procedure.
> > Without this patche, issuing reboot from shell doesn't reboot the=20
> > machine.
> >
> > Signed-off-by: Dai Haruki <dai.haruki@freescale.com>
>=20
> Dai, I'm avoid taking patches for 85xx that effect new=20
> functionality.  If you want change this to work with=20
> arch/powerpc and make it a run time check for 8548.

Hi Kumar, what kind of new feature is affected by this bug fix? 8548
requires reboot to set the hardware reset bits. The mpc85xx_restart() is
not ported to arch/powerpc yet. Which portion of the arch/powerpc code
should be modified in order to restart the machine correctly?=20
And how do you want me to do run time check? Check SVR?=20

Dai=20

>=20
> - kumar
>=20
> > ---
> >
> >  arch/ppc/syslib/ppc85xx_setup.c |    5 +++++
> >  1 files changed, 5 insertions(+), 0 deletions(-)
> >
> > 8f095006923385c3546165b0e10d73d3e057c120
> > diff --git a/arch/ppc/syslib/ppc85xx_setup.c=20
> > b/arch/ppc/syslib/ppc85xx_setup.c index e4dda43..45b1b2b 100644
> > --- a/arch/ppc/syslib/ppc85xx_setup.c
> > +++ b/arch/ppc/syslib/ppc85xx_setup.c
> > @@ -115,6 +115,11 @@ mpc85xx_early_serial_map(void)  void =20
> > mpc85xx_restart(char *cmd)  {
> > +#ifdef CONFIG_MPC8548
> > +	volatile unsigned int *rstcr;
> > +	u32 *pMem =3D (u32*) ioremap((BOARD_CCSRBAR + 0xe00b0),0x100);
> > +	*pMem =3D 0x2; /* Set HRESET_REQ flag */ #endif
> >  	local_irq_disable();
> >  	abort();
> >  }
> > --
> > 1.2.4
> > _______________________________________________
> > Linuxppc-dev mailing list
> > Linuxppc-dev@ozlabs.org
> > https://ozlabs.org/mailman/listinfo/linuxppc-dev
>=20
>=20

Re: [PATCH] Fix MPC8548CDS rebooting procedure

[Kumar Gala]

On Mar 8, 2006, at 1:24 PM, Haruki Dai-r35557 wrote:

>> -----Original Message-----
>> From: Kumar Gala [mailto:galak@kernel.crashing.org]
>> Sent: Wednesday, March 08, 2006 12:33 PM
>> To: Haruki Dai-r35557
>> Cc: linuxppc-dev@ozlabs.org
>> Subject: Re: [PATCH] Fix MPC8548CDS rebooting procedure
>>
>>
>> On Mar 8, 2006, at 11:22 AM, Haruki Dai-r35557 wrote:
>>
>>> This patch fixes the MPC8548 CDS rebooting procedure.
>>> Without this patche, issuing reboot from shell doesn't reboot the
>>> machine.
>>>
>>> Signed-off-by: Dai Haruki <dai.haruki@freescale.com>
>>
>> Dai, I'm avoid taking patches for 85xx that effect new
>> functionality.  If you want change this to work with
>> arch/powerpc and make it a run time check for 8548.
>
> Hi Kumar, what kind of new feature is affected by this bug fix? 8548
> requires reboot to set the hardware reset bits. The mpc85xx_restart 
> () is
> not ported to arch/powerpc yet. Which portion of the arch/powerpc code
> should be modified in order to restart the machine correctly?
> And how do you want me to do run time check? Check SVR?

Restart has never worked properly on the 85xx boards from freescale  
since they never provided a reasonable way to reset the systems in  
software.  So I consider this new functionality at this point.

The powerpc.git tree has an arch/powerpc/platforms/85xx/misc.c that  
has a mpc85xx_restart() in it.

As for run time checking, yes use something like SVR or PVR to  
determine the feature.  In this case its probably best to using  
something like PVR and check for E500r1.  I imagine 8540, 8541, 8555,  
8560 don't support this feature (all e500r1), but all future 8548 and  
newer parts will (e500r2, etc.)

- kumar

RE: [PATCH] Fix MPC8548CDS rebooting procedure

[Haruki Dai-r35557]

> -----Original Message-----
> From: Kumar Gala [mailto:galak@kernel.crashing.org]=20
> Sent: Wednesday, March 08, 2006 9:14 PM
> To: Haruki Dai-r35557
> Cc: linuxppc-dev@ozlabs.org
> Subject: Re: [PATCH] Fix MPC8548CDS rebooting procedure
>=20
>=20
> On Mar 8, 2006, at 1:24 PM, Haruki Dai-r35557 wrote:
>=20
> >> -----Original Message-----
> >> From: Kumar Gala [mailto:galak@kernel.crashing.org]
> >> Sent: Wednesday, March 08, 2006 12:33 PM
> >> To: Haruki Dai-r35557
> >> Cc: linuxppc-dev@ozlabs.org
> >> Subject: Re: [PATCH] Fix MPC8548CDS rebooting procedure
> >>
> >>
> >> On Mar 8, 2006, at 11:22 AM, Haruki Dai-r35557 wrote:
> >>
> >>> This patch fixes the MPC8548 CDS rebooting procedure.
> >>> Without this patche, issuing reboot from shell doesn't reboot the=20
> >>> machine.
> >>>
> >>> Signed-off-by: Dai Haruki <dai.haruki@freescale.com>
> >>
> >> Dai, I'm avoid taking patches for 85xx that effect new=20
> functionality. =20
> >> If you want change this to work with arch/powerpc and make=20
> it a run=20
> >> time check for 8548.
> >
> > Hi Kumar, what kind of new feature is affected by this bug=20
> fix? 8548=20
> > requires reboot to set the hardware reset bits. The mpc85xx_restart
> > () is
> > not ported to arch/powerpc yet. Which portion of the=20
> arch/powerpc code=20
> > should be modified in order to restart the machine correctly?
> > And how do you want me to do run time check? Check SVR?
>=20
> Restart has never worked properly on the 85xx boards from=20
> freescale since they never provided a reasonable way to reset=20
> the systems in software.  So I consider this new=20
> functionality at this point.
>=20
> The powerpc.git tree has an=20
> arch/powerpc/platforms/85xx/misc.c that has a mpc85xx_restart() in it.

Thanks. I didn't work on the powerpc.git tree.  I will submit the patch
based on the powerpc.git tree.

>=20
> As for run time checking, yes use something like SVR or PVR=20
> to determine the feature.  In this case its probably best to=20
> using something like PVR and check for E500r1.  I imagine=20
> 8540, 8541, 8555, 8560 don't support this feature (all=20
> e500r1), but all future 8548 and newer parts will (e500r2, etc.)

OK. I will modify it as you suggest.=20

regards,
Dai.

>=20
> - kumar
>=20