From: Timur Tabi <timur@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, tnt@246tNt.com
Subject: Re: [PATCH v2] powerpc: change rheap functions to use ulongs instead of pointers
Date: Tue, 10 Apr 2007 14:09:32 -0500 [thread overview]
Message-ID: <461BE0EC.8090204@freescale.com> (raw)
In-Reply-To: <EB6E9F47-C92F-48E0-BC98-13AA3B9C0027@kernel.crashing.org>
Kumar Gala wrote:
> What's the specific problem you are fixing? Its not obvious that this
> patch is addressing a bug.
problem != bug
The problem is that a pointer implies something you can dereference. But the return value
from rh_alloc() is only a pointer in a specific circumstance which is not actually used in
any current code. So *all* of the callers of rh_alloc() cast the return value to an
integer type anyway.
In other words, it's wrong to use a pointer. The value is a generic number, and so the
type needs to match that. The code is just better using ulongs. Also, two redundant
macros (IS_MURAM_ERR, etc) have been removed and replaced with their generic counterpart
(IS_ERR_VALUE).
--
Timur Tabi
Linux Kernel Developer @ Freescale
next prev parent reply other threads:[~2007-04-10 19:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-04 22:07 [PATCH v2] powerpc: change rheap functions to use ulongs instead of pointers Timur Tabi
2007-04-09 21:25 ` Timur Tabi
2007-04-10 18:31 ` Kumar Gala
2007-04-10 18:46 ` Timur Tabi
2007-04-10 19:04 ` Kumar Gala
2007-04-10 19:09 ` Timur Tabi [this message]
2007-04-10 19:32 ` Kumar Gala
2007-04-10 19:42 ` Sylvain Munaut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=461BE0EC.8090204@freescale.com \
--to=timur@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=tnt@246tNt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).