From: Mark Lord <liml@rtr.ca>
To: Michael <michaelzwrk@gmail.com>
Cc: linux-ide@vger.kernel.org, Jeff Garzik <jeff@garzik.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linuxppc-embedded@ozlabs.org
Subject: Re: IDE driver in polling mode
Date: Thu, 12 Apr 2007 09:39:03 -0400 [thread overview]
Message-ID: <461E3677.6030104@rtr.ca> (raw)
In-Reply-To: <1ea6be8e0704110810l205f5dc7gb831603455a883e2@mail.gmail.com>
Michael,
Here is a patch to have drivers/ide use polling
for all operations, in addition to IRQs.
Patch is against 2.6.21, but should apply and work equally well
on earlier kernels (including 2.6.14).
This quick hack is *not* for general kernel inclusion.
It works for me. I tested it using a CF card in a PC-CARD adapter.
Signed-off-by: Mark Lord <mlord@pobox.com>
--- 2.6.21/drivers/ide/ide-probe.c 2007-04-11 00:18:51.000000000 -0400
+++ new/drivers/ide/ide-probe.c 2007-04-12 09:26:14.000000000 -0400
@@ -1014,6 +1014,27 @@
* but anything else has led to problems on some machines. We re-enable
* interrupts as much as we can safely do in most places.
*/
+struct timer_list polling_timer;
+static void ide_polling (unsigned long data)
+{
+ ide_hwgroup_t *hwgroup = (void *)data;
+ ide_hwif_t *hwif;
+ int irq = 0;
+
+ if (hwgroup) {
+ hwif = hwgroup->hwif;
+ if (hwif)
+ irq = hwif->irq;
+ }
+
+ ide_intr(irq, hwgroup);
+ init_timer(&polling_timer);
+ polling_timer.expires = jiffies + 1;
+ polling_timer.function = &ide_polling;
+ polling_timer.data = (unsigned long) hwgroup;
+ add_timer(&polling_timer);
+}
+
static int init_irq (ide_hwif_t *hwif)
{
unsigned int index;
@@ -1110,9 +1131,12 @@
if (hwif->io_ports[IDE_CONTROL_OFFSET])
/* clear nIEN */
hwif->OUTB(0x08, hwif->io_ports[IDE_CONTROL_OFFSET]);
-
+#if 0
if (request_irq(hwif->irq,&ide_intr,sa,hwif->name,hwgroup))
goto out_unlink;
+#else
+ ide_polling((unsigned long)hwgroup);
+#endif
}
/*
@@ -1156,6 +1180,7 @@
printk("\n");
up(&ide_cfg_sem);
return 0;
+#if 0
out_unlink:
spin_lock_irq(&ide_lock);
if (hwif->next == hwif) {
@@ -1176,6 +1201,7 @@
BUG_ON(hwgroup->hwif == hwif);
}
spin_unlock_irq(&ide_lock);
+#endif
out_up:
up(&ide_cfg_sem);
return 1;
--- 2.6.21/drivers/ide/ide.c 2007-04-11 00:18:51.000000000 -0400
+++ new/drivers/ide/ide.c 2007-04-12 09:31:59.000000000 -0400
@@ -569,6 +569,8 @@
* This is raving bonkers.
*/
+extern struct timer_list polling_timer;
+
void ide_unregister(unsigned int index)
{
ide_drive_t *drive;
@@ -612,7 +614,11 @@
g = g->next;
} while (g != hwgroup->hwif);
if (irq_count == 1)
+#if 0
free_irq(hwif->irq, hwgroup);
+#else
+ del_timer(&polling_timer);
+#endif
spin_lock_irq(&ide_lock);
/*
next prev parent reply other threads:[~2007-04-12 13:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-10 13:35 IDE driver in polling mode Michael
2007-04-10 14:19 ` Sergei Shtylyov
2007-04-10 14:44 ` Mark Lord
2007-04-10 15:31 ` Michael
2007-04-10 16:11 ` Alan Cox
2007-04-10 16:18 ` Jeff Garzik
2007-04-10 16:29 ` Alan Cox
2007-04-11 8:39 ` Michael
2007-04-11 8:47 ` Alan Cox
2007-04-11 15:10 ` Michael
2007-04-11 15:23 ` Alan Cox
2007-04-12 13:39 ` Mark Lord [this message]
2007-04-12 13:40 ` Mark Lord
2007-04-12 13:43 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=461E3677.6030104@rtr.ca \
--to=liml@rtr.ca \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=michaelzwrk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).