From: Dave Jiang <djiang@mvista.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH] add reg and stack dump to booke WD handler
Date: Fri, 13 Apr 2007 13:26:25 -0700 [thread overview]
Message-ID: <461FE771.2010908@mvista.com> (raw)
In-Reply-To: <B8CF9F53-9F51-4DD5-9CB6-16C69502A1CA@kernel.crashing.org>
Kumar Gala wrote:
>
> On Apr 13, 2007, at 3:06 PM, Dave Jiang wrote:
>
>> Have the booke watchdog dump some useful information when triggered.
>> Hopefully
>> that'll give the user some hint of what happened rather than just a
>> mysterious
>> reboot.
>
> Forgot the signed-off-by again (git-commit -s)
>
I need to stop doing that! Grrrrr....
>> --
>>
>> Ok here's try 2. Modified the watchdog driver instead per Sergei's
>> suggestion.
>
> I'm against having a WatchdogHandler in booke_wdt.c. The idea behind
> the weak symbol in traps.c is to allow platform code to override the
> behavior. I'm ok if we put the spew in the generic case.
>
Ok, I will put it back in the generic handler.
> Also, how are you testing this?
I just stop the userland watchdog daemon and the watchdog timeout kicks
in. Of course I could also write a kernel module that takes a spinlock
and spin.... I tested on the MPC8548 and seems to work as expected.
next prev parent reply other threads:[~2007-04-13 20:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-13 17:35 [PATCH] add reg and stack dump to booke WD handler Dave Jiang
2007-04-13 17:47 ` oops, forgot to sign off Dave Jiang
2007-04-13 18:26 ` [PATCH] add reg and stack dump to booke WD handler Sergei Shtylyov
2007-04-13 20:06 ` Dave Jiang
2007-04-13 20:11 ` Kumar Gala
2007-04-13 20:26 ` Dave Jiang [this message]
2007-04-13 20:28 ` Sergei Shtylyov
2007-04-13 22:16 ` Dave Jiang
2007-04-24 4:01 ` Paul Mackerras
2007-04-27 17:01 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=461FE771.2010908@mvista.com \
--to=djiang@mvista.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).