From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <46218A5D.80805@gmail.com> Date: Sat, 14 Apr 2007 22:13:49 -0400 From: Jerry Van Baren MIME-Version: 1.0 To: Linuxppc-dev@ozlabs.org Subject: Re: [PATCH dtc] Implement the -R option and add a -S option. References: <20070405020433.GA13891@dellserver.lan> <20070405161113.GA28063@ld0162-tx32.am.freescale.net> <46152D90.5070209@smiths-aerospace.com> <20070412065152.GA26210@localhost.localdomain> <4620D009.1000800@gmail.com> <20070415004229.GD9104@localhost.localdomain> In-Reply-To: <20070415004229.GD9104@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , David Gibson wrote: > On Sat, Apr 14, 2007 at 08:58:49AM -0400, Jerry Van Baren wrote: [snip] >> On an unrelated related note, I don't believe my -R additions are >> actually putting out additional reserve map slots (easiest to see using >> the asm format output). I'm still trying to understand why not, it >> seemed pretty straight-forward. When I implemented it, I was looking at >> hexdumps of the dtb binary format and looking at the header and thought >> I had it working... using it with my u-boot mods shows no extra reserved >> slots. I'm looking into where I went wrong. > > Be careful to check the actual offsets. Bear in mind that objdump may > elide zero words. Also bear in mind that the only way a reader of the > device tree has of counting the number of reserve entries is stepping > through until it hits the terminating (0,0), so the extra entries will > just look like an early termination of the list. In this sense -R > doesn't add "extra slots", but just ensures that there is space after > the reserve map to add more entries. Hi David, It actually is OK, went back and verified it. I needed to modify the asm output to implement the -R extra slots which was confusing me (patch that you didn't like the calloc in ;-). The calloc change was actually window dressing, I was just being paranoid about a binary blob that is bigger than its contents (has extra space). The unused space is unused, so it doen't really matter if it is non-zero. I'll roll a new version. gvb