From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.genesi-usa.com (mithrandir.softwarenexus.net [66.98.186.96]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id B898ADDF10 for ; Thu, 26 Apr 2007 03:46:09 +1000 (EST) Message-ID: <462F93F0.5090608@genesi-usa.com> Date: Wed, 25 Apr 2007 18:46:24 +0100 From: Matt Sealey MIME-Version: 1.0 To: Segher Boessenkool Subject: Re: [PATCH 3/6] Consolidate of_find_property References: <20070403105217.7b9fea08.sfr@canb.auug.org.au> <20070403223914.35bf04e1.sfr@canb.auug.org.au> <20070403224039.913af749.sfr@canb.auug.org.au> <20070403224205.807cffe0.sfr@canb.auug.org.au> <20070403224340.5533abc9.sfr@canb.auug.org.au> <20070403224505.5d5a1495.sfr@canb.auug.org.au> <20070403224610.b61c7377.sfr@canb.auug.org.au> <20070403224937.f6a07e56.sfr@canb.auug.org.au> <20070403225059.e735b5e4.sfr@canb.auug.org.au> <20070403225222.88e92221.sfr@canb.auug.org.au> <20070403230505.f96ea210.sfr@canb.auug.org.au> <20070403232406.ab9a3c86.sfr@canb.auug.org.au> <20070412141905.6f30efd3.sfr@canb.auug.org.au> <20070412153424.bf3957f4.sfr@canb.auug.org.au> <20070424223245.78f4fdfb.sfr@canb.auug.org.au> <20070424223930.1dab0e28.sfr@canb.auug .org.au> <06c51eb59847d80d9225cd6454f1957e@kernel.crashing.org> <17966.45645.902486.793443@cargo.ozlabs.ibm.com> <1177477630.14873.185.camel@localhost.localdomain> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Cc: Stephen Rothwell , Paul Mackerras , "David S. Miller" , ppc-dev List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Can't the ata/ATA thing be fixed by simply fixing device trees where it happens? strncmp seems the standards-compliant route to take.. why clutter the common parsing routines with fixes for deviant platforms? The Mac obviously has a few of_platform things where you can add a compatible search for ata then ATA, keeping it all in the drivers (where relevant) and in the platform setup (where necessary) -- Matt Sealey Genesi, Manager, Developer Relations Segher Boessenkool wrote: >>> The question is, what ppc drivers would break if we used strcmp >>> instead of strcasecmp? I have a dim memory that some Apple machines >>> had "ata" and others had "ATA" for the hard disk, for instance. >> ata/ATA and ide/IDE is the main one that comes to mind, but I wouldn't >> exclude something like Powermac vs. PowerMac or that sort of thing... I >> remember a case related bug about 2 years ago but can't find what it >> was ... >> >> I think it's safe to settle on strcasecmp for most things for now > > Yes, it's hard to imagine any case where strcasecmp(), > although technically incorrect, would break anything. > Please document in the code that is _is_ wrong and _why_ > it is done though. > > > Segher > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev