From: Scott Wood <scottwood@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: netdev@vger.kernel.org, jgarzik@pobox.com, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2] gianfar: Add I/O barriers when touching buffer descriptor ownership.
Date: Wed, 02 May 2007 15:12:52 -0500 [thread overview]
Message-ID: <4638F0C4.2000406@freescale.com> (raw)
In-Reply-To: <F1B250DD-A472-470F-B3D0-EBB2F042E454@kernel.crashing.org>
Kumar Gala wrote:
> I'd rather see a wmb() instead of eieio() to keep this code non-ppc
> specific. (also, we implement wmb as eieio, so I don't keep the
> comment about it being too heavy, unless you mean generically).
wmb() is a sync, smp_wmb() is an eieio. Andy told me he would not
accept a sync in those spots.
And the driver is already ppc-specific; it uses in/out_be32.
-Scott
next prev parent reply other threads:[~2007-05-02 20:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-02 19:57 [PATCH v2] gianfar: Add I/O barriers when touching buffer descriptor ownership Scott Wood
2007-05-02 20:09 ` Kumar Gala
2007-05-02 20:12 ` Scott Wood [this message]
2007-05-02 20:20 ` Kumar Gala
2007-05-02 20:40 ` Scott Wood
2007-05-02 21:23 ` Kumar Gala
2007-05-02 21:30 ` Scott Wood
2007-05-03 2:10 ` Kumar Gala
2007-05-03 16:00 ` Scott Wood
2007-05-03 16:38 ` Segher Boessenkool
2007-05-02 23:42 ` Segher Boessenkool
2007-05-04 22:13 ` Linas Vepstas
2007-05-04 23:24 ` Olof Johansson
2007-05-05 0:41 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4638F0C4.2000406@freescale.com \
--to=scottwood@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=jgarzik@pobox.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).