From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nommos.sslcatacombnetworking.com (nommos.sslcatacombnetworking.com [67.18.224.114]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 1ED2C67B59 for ; Fri, 4 Aug 2006 02:46:33 +1000 (EST) In-Reply-To: <44D21AFA.2010900@ru.mvista.com> References: <1154544503.19994.42.camel@cashmere.sps.mot.com> <9C1B15CC-6984-433D-8A1E-F856567B1AD2@kernel.crashing.org> <1154549483.19994.46.camel@cashmere.sps.mot.com> <1154550970.19994.57.camel@cashmere.sps.mot.com> <44D21AFA.2010900@ru.mvista.com> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <4644A4A2-0A49-45A8-AAFD-67647AB44EB8@kernel.crashing.org> From: Kumar Gala Subject: Re: [PATCH] Add MPC8641 HPCN Device Tree Source file. Date: Thu, 3 Aug 2006 11:46:33 -0500 To: Sergei Shtylyov Cc: "linuxppc-dev@ozlabs.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Aug 3, 2006, at 10:49 AM, Sergei Shtylyov wrote: > Hello. > > Kumar Gala wrote: >> Here is the code modification to fsl_soc.c, I'm sure we can get >> this fixed push into 2.6.18 if desired. > >> if(mac_addr = get_property(np, "address", NULL)) >> memcpy(gfar_data.mac_addr, mac_addr, 6); >> if(mac_addr = get_property(np, "local-mac-address", NULL); >> memcpy(gfar_data.mac_addr, mac_addr, 6); > > BTW, doesn't it also have sense to convert gianfar.c to using > of_device instead of platform_device? We can't do that until all consumers from arch/ppc are gone. - k