From: Scott Wood <scottwood@freescale.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: Consolidate cuboot initialization code
Date: Wed, 30 May 2007 10:09:11 -0500 [thread overview]
Message-ID: <465D9397.7000008@freescale.com> (raw)
In-Reply-To: <20070530020110.GC21955@localhost.localdomain>
David Gibson wrote:
> +void cuboot_init(unsigned long r4, unsigned long r5,
> + unsigned long r6, unsigned long r7,
> + unsigned long end_of_ram);
> +
> +#define CUBOOT_INIT() \
> + do { \
> + memcpy(&bd, (bd_t *)r3, sizeof(bd)); \
> + cuboot_init(r4, r5, r6, r7, bd.bi_memstart + bd.bi_memsize); \
> + } while (0)
Is there any particular reason to not just do a direct call to
cuboot_init, and move the memcpy and end-of-ram calculation there? I'd
rather avoid macros if possible.
Also, the "extern char _dtb_start[], _dtb_end[];" line in cuboot.c
doesn't appear to be needed.
Other than that, it looks good.
-Scott
next prev parent reply other threads:[~2007-05-30 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-30 2:01 Consolidate cuboot initialization code David Gibson
2007-05-30 15:09 ` Scott Wood [this message]
2007-05-30 15:12 ` David Gibson
2007-05-30 15:21 ` Scott Wood
2007-05-31 1:33 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465D9397.7000008@freescale.com \
--to=scottwood@freescale.com \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).