From: Geoff Levand <geoffrey.levand@am.sony.com>
To: Michael Neuling <mikey@neuling.org>
Cc: dwmw2@infradead.org, kexec@lists.infradead.org,
Milton Miller <miltonm@bga.com>,
linuxppc-dev@ozlabs.org, horms@verge.net.au
Subject: Re: [PATCH] kexec ppc64: fix misaligned cmdline
Date: Thu, 07 Jun 2007 09:19:07 -0700 [thread overview]
Message-ID: <46682FFB.7000000@am.sony.com> (raw)
In-Reply-To: <10188.1181179162@neuling.org>
Michael Neuling wrote:
> If the cmdline changes between boots, we can get misalignment of the
> bootargs entry, which in turn corrupts our device tree blob and hence
> kills our kexec boot. Also, if there was no /chosen/bootargs
> previously, we'd never add a new one.
>
> This ignores the bootargs while parsing the tree and inserts it later.
>
> Signed-off-by: Michael Neuling <mikey@neuling.org>
Hi.
Acked-by: Geoff Levand <geoffrey.levand@am.sony.com>
I tested this with PS3 and it works as expected. I added it to my
ps3-kexec-tools.git. With this patch mainline kexec will work
with the PS3.
I still have a work-in-progress patch started by David Woodhouse
to support building a 32 bit kexec executable for PPC64 platforms.
I don't have any definite plan to work on it though.
-Geoff
next prev parent reply other threads:[~2007-06-07 16:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-04 7:23 [PATCH] kexec ppc64: fix misaligned cmdline Michael Neuling
2007-06-04 9:22 ` Milton Miller
2007-06-04 9:42 ` Michael Neuling
2007-06-07 1:19 ` Michael Neuling
2007-06-07 16:19 ` Geoff Levand [this message]
2007-06-19 5:06 ` Horms
2007-06-04 23:49 ` David Gibson
2007-06-04 23:56 ` Michael Neuling
2007-06-05 0:16 ` David Gibson
2007-06-05 0:58 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46682FFB.7000000@am.sony.com \
--to=geoffrey.levand@am.sony.com \
--cc=dwmw2@infradead.org \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=miltonm@bga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).