linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@lists.ozlabs.org
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Build regressions/improvements in v4.0-rc3
Date: Mon, 09 Mar 2015 15:10:49 +0100	[thread overview]
Message-ID: <4677994.NrntHOKO7A@wuerfel> (raw)
In-Reply-To: <CAMuHMdVNWVKA0iuTMABQPzJJtjCAD_Ey7w1gx2ojYzG4TscyKA@mail.gmail.com>

On Monday 09 March 2015 11:56:22 Geert Uytterhoeven wrote:
> On Mon, Mar 9, 2015 at 11:50 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > JFYI, when comparing v4.0-rc3[1] to v4.0-rc2[3], the summaries are:
> >   - build errors: +18/-7
> 
>   + /home/kisskb/slave/src/arch/arm/mach-pxa/idp.c: error:
> 'SMC91X_NOWAIT' undeclared here (not in a function):  => 85:47
>   + /home/kisskb/slave/src/arch/arm/mach-pxa/idp.c: error:
> 'SMC91X_USE_32BIT' undeclared here (not in a function):  => 85:11
>   + /home/kisskb/slave/src/arch/arm/mach-pxa/idp.c: error:
> 'SMC91X_USE_DMA' undeclared here (not in a function):  => 85:30
>   + /home/kisskb/slave/src/arch/arm/mach-pxa/idp.c: error: unknown
> field 'flags' specified in initializer:  => 85:2
>   + /home/kisskb/slave/src/arch/arm/mach-pxa/idp.c: error: variable
> 'smc91x_platdata' has initializer but incomplete type:  => 84:15
> 
> pxa255-idp_defconfig
> 
>   + /home/kisskb/slave/src/arch/arm/mach-pxa/lpd270.c: error: expected
> '}' before ';' token:  => 198:43
> 
> lpd270_defconfig
> 
>   + /home/kisskb/slave/src/arch/arm/mach-sa1100/neponset.c: error:
> 'smc91c_platdata' undeclared (first use in this function):  => 271:12
> 
> neponset_defconfig
> 
>   + /home/kisskb/slave/src/arch/arm/mach-sa1100/pleb.c: error:
> 'smc91c_platdata' undeclared here (not in a function):  => 57:22
> 
> pleb_defconfig
> 
>   + /home/kisskb/slave/src/drivers/net/ethernet/smsc/smc91x.c: error:
> implicit declaration of function 'machine_has_neponset'
> [-Werror=implicit-function-declaration]:  => 2363:2
> 
> neponset_defconfig
> 
> smc91x fallout. The lpd270_defconfig failure looks like not covered by
> "ARM: fix typos in smc91x platform data" yet?

It's not?

This should be part of that patch:

--- a/arch/arm/mach-pxa/lpd270.c
+++ b/arch/arm/mach-pxa/lpd270.c
@@ -195,7 +195,7 @@ static struct resource smc91x_resources[] = {
 };
 
 struct smc91x_platdata smc91x_platdata = {
-       .flags = SMC91X_USE_16BIT | SMC91X_NOWAIT;
+       .flags = SMC91X_USE_16BIT | SMC91X_NOWAIT,
 };
 
 static struct platform_device smc91x_device = {

and I thought I had tested all defconfigs as well as hundreds of randconfigs
(the right ones) successfully this time.


	Arnd

  reply	other threads:[~2015-03-09 14:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1425898222-19721-1-git-send-email-geert@linux-m68k.org>
2015-03-09 10:56 ` Build regressions/improvements in v4.0-rc3 Geert Uytterhoeven
2015-03-09 14:10   ` Arnd Bergmann [this message]
2015-03-09 14:27     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4677994.NrntHOKO7A@wuerfel \
    --to=arnd@arndb.de \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).