From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.wrs.com (mail.windriver.com [147.11.1.11]) by ozlabs.org (Postfix) with ESMTP id 8951CDDEF4 for ; Tue, 3 Jul 2007 02:37:26 +1000 (EST) Message-ID: <4689025C.8000001@windriver.com> Date: Mon, 02 Jul 2007 08:49:16 -0500 From: Jason Wessel MIME-Version: 1.0 To: Sergei Shtylyov Subject: Re: 2.6.22-rc6-mm1 References: <20070628034321.38c9f12b.akpm@linux-foundation.org> <200706291432.10128.m.kozlowski@tuxland.pl> <4685010C.4000108@ru.mvista.com> In-Reply-To: <4685010C.4000108@ru.mvista.com> Content-Type: multipart/mixed; boundary="------------070207060901030309020002" Cc: kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Mariusz Kozlowski , paulus@samba.org, Andrew Morton List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , This is a multi-part message in MIME format. --------------070207060901030309020002 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sergei Shtylyov wrote: > Hello. > > Mariusz Kozlowski wrote: > > >> allmodconfig on powerpc (iMac g3) fails due to >> git-kgdb.patch. allmodconfig defaults should be changed? >> > > >> CC arch/powerpc/kernel/kgdb.o >> arch/powerpc/kernel/kgdb.c:485:2: error: #error Both XMON and KGDB selected >> in .config. Unselect one of them. >> make[1]: *** [arch/powerpc/kernel/kgdb.o] Blad 1 >> make: *** [arch/powerpc/kernel] Blad 2 >> > > I'm not sure if this will work out but maybe it's worth to disable XMON if > KGDB is selected, like this? > > config XMON > bool "Include xmon kernel debugger" > depends on DEBUGGER && !KGDB > > It did not seem that you can make a radio button / multi-select kernel config option unless the options are in the same Kconfig file. Given that xmon and kgdb are mutually exclusive at the moment. What Sergei mentioned is the fix that needs to be used for the time being. Attached is the patch I put in the for_mm branch in the linux-2.6-kgdb git tree. Jason. --------------070207060901030309020002 Content-Type: text/plain; name="xmon_or_kgdb.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="xmon_or_kgdb.patch" xmon_or_kgdb.patch From: Jason Wessel Subject: [PATCH] Turn off xmon if kgdb is active on ppc and powerpc Xmon and kgdb are mutuall exclusive at the moment so xmon should be turned off in the kernel config options if kgdb selected. The case with "make allmodconfig" was failing and this patch addresses the problem. Signed-off-by: Jason Wessel --- arch/powerpc/Kconfig.debug | 2 +- arch/ppc/Kconfig.debug | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6-kgdb/arch/powerpc/Kconfig.debug =================================================================== --- linux-2.6-kgdb.orig/arch/powerpc/Kconfig.debug +++ linux-2.6-kgdb/arch/powerpc/Kconfig.debug @@ -43,7 +43,7 @@ config HCALL_STATS config XMON bool "Include xmon kernel debugger" - depends on DEBUG_KERNEL + depends on DEBUG_KERNEL && !KGDB help Include in-kernel hooks for the xmon kernel monitor/debugger. Unless you are intending to debug the kernel, say N here. Index: linux-2.6-kgdb/arch/ppc/Kconfig.debug =================================================================== --- linux-2.6-kgdb.orig/arch/ppc/Kconfig.debug +++ linux-2.6-kgdb/arch/ppc/Kconfig.debug @@ -4,7 +4,7 @@ source "lib/Kconfig.debug" config XMON bool "Include xmon kernel debugger" - depends on DEBUG_KERNEL + depends on DEBUG_KERNEL && !KGDB help Include in-kernel hooks for the xmon kernel monitor/debugger. Unless you are intending to debug the kernel, say N here. --------------070207060901030309020002--