Re: 2.6.22-rc6-mm1

Re: 2.6.22-rc6-mm1

[Mariusz Kozlowski]

Hello,

	allmodconfig on powerpc (iMac g3) fails due to
git-kgdb.patch. allmodconfig defaults should be changed?

  CC      arch/powerpc/kernel/kgdb.o
arch/powerpc/kernel/kgdb.c:485:2: error: #error Both XMON and KGDB selected 
in .config. Unselect one of them.
make[1]: *** [arch/powerpc/kernel/kgdb.o] Blad 1
make: *** [arch/powerpc/kernel] Blad 2

anyway after unselecting XMON we can see:

  CC [M]  fs/xfs/linux-2.6/xfs_ioctl32.o
fs/xfs/linux-2.6/xfs_ioctl32.c: In function 'xfs_ioc_bulkstat_compat':
fs/xfs/linux-2.6/xfs_ioctl32.c:334: error: 'xfs_inumbers_fmt_compat' 
undeclared (first use in this function)
fs/xfs/linux-2.6/xfs_ioctl32.c:334: error: (Each undeclared identifier is 
reported only once
fs/xfs/linux-2.6/xfs_ioctl32.c:334: error: for each function it appears in.)
make[2]: *** [fs/xfs/linux-2.6/xfs_ioctl32.o] Blad 1
make[1]: *** [fs/xfs] Blad 2

This is just allmodconfig - not a .config that's used daily by users but I'm 
used to compiling the kernel using it anyway 8)

Regards,

	Mariusz

Re: 2.6.22-rc6-mm1

[Sergei Shtylyov]

Hello.

Mariusz Kozlowski wrote:

> 	allmodconfig on powerpc (iMac g3) fails due to
> git-kgdb.patch. allmodconfig defaults should be changed?

>   CC      arch/powerpc/kernel/kgdb.o
> arch/powerpc/kernel/kgdb.c:485:2: error: #error Both XMON and KGDB selected 
> in .config. Unselect one of them.
> make[1]: *** [arch/powerpc/kernel/kgdb.o] Blad 1
> make: *** [arch/powerpc/kernel] Blad 2

    I'm not sure if this will work out but maybe it's worth to disable XMON if 
KGDB is selected, like this?

config XMON
	bool "Include xmon kernel debugger"
	depends on DEBUGGER && !KGDB

> Regards,

> 	Mariusz

WBR, Sergei

Re: 2.6.22-rc6-mm1

[Jason Wessel]

[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]

Sergei Shtylyov wrote:
> Hello.
>
> Mariusz Kozlowski wrote:
>
>   
>> 	allmodconfig on powerpc (iMac g3) fails due to
>> git-kgdb.patch. allmodconfig defaults should be changed?
>>     
>
>   
>>   CC      arch/powerpc/kernel/kgdb.o
>> arch/powerpc/kernel/kgdb.c:485:2: error: #error Both XMON and KGDB selected 
>> in .config. Unselect one of them.
>> make[1]: *** [arch/powerpc/kernel/kgdb.o] Blad 1
>> make: *** [arch/powerpc/kernel] Blad 2
>>     
>
>     I'm not sure if this will work out but maybe it's worth to disable XMON if 
> KGDB is selected, like this?
>
> config XMON
> 	bool "Include xmon kernel debugger"
> 	depends on DEBUGGER && !KGDB
>
>   

It did not seem that you can make a radio button / multi-select kernel 
config option unless the options are in the same Kconfig file.  Given 
that xmon and kgdb are mutually exclusive at the moment.

What Sergei mentioned is the fix that needs to be used for the time being. 

Attached is the patch I put in the for_mm branch in the linux-2.6-kgdb 
git tree.

Jason.



[-- Attachment #2: xmon_or_kgdb.patch --]
[-- Type: text/plain, Size: 1532 bytes --]

xmon_or_kgdb.patch

From: Jason Wessel <jason.wessel@windriver.com>
Subject: [PATCH] Turn off xmon if kgdb is active on ppc and powerpc

Xmon and kgdb are mutuall exclusive at the moment so xmon should be
turned off in the kernel config options if kgdb selected.  The case with "make allmodconfig" was failing and this patch addresses the problem.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>

---
 arch/powerpc/Kconfig.debug |    2 +-
 arch/ppc/Kconfig.debug     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Index: linux-2.6-kgdb/arch/powerpc/Kconfig.debug
===================================================================
--- linux-2.6-kgdb.orig/arch/powerpc/Kconfig.debug
+++ linux-2.6-kgdb/arch/powerpc/Kconfig.debug
@@ -43,7 +43,7 @@ config HCALL_STATS
 
 config XMON
 	bool "Include xmon kernel debugger"
-	depends on DEBUG_KERNEL
+	depends on DEBUG_KERNEL && !KGDB
 	help
 	  Include in-kernel hooks for the xmon kernel monitor/debugger.
 	  Unless you are intending to debug the kernel, say N here.
Index: linux-2.6-kgdb/arch/ppc/Kconfig.debug
===================================================================
--- linux-2.6-kgdb.orig/arch/ppc/Kconfig.debug
+++ linux-2.6-kgdb/arch/ppc/Kconfig.debug
@@ -4,7 +4,7 @@ source "lib/Kconfig.debug"
 
 config XMON
 	bool "Include xmon kernel debugger"
-	depends on DEBUG_KERNEL
+	depends on DEBUG_KERNEL && !KGDB
 	help
 	  Include in-kernel hooks for the xmon kernel monitor/debugger.
 	  Unless you are intending to debug the kernel, say N here.

Re: 2.6.22-rc6-mm1

[Sergei Shtylyov]

Hello.

Jason Wessel wrote:

>>>     allmodconfig on powerpc (iMac g3) fails due to
>>> git-kgdb.patch. allmodconfig defaults should be changed?

>>>   CC      arch/powerpc/kernel/kgdb.o
>>> arch/powerpc/kernel/kgdb.c:485:2: error: #error Both XMON and KGDB 
>>> selected in .config. Unselect one of them.
>>> make[1]: *** [arch/powerpc/kernel/kgdb.o] Blad 1
>>> make: *** [arch/powerpc/kernel] Blad 2

>>     I'm not sure if this will work out but maybe it's worth to disable 
>> XMON if KGDB is selected, like this?
>> config XMON
>>     bool "Include xmon kernel debugger"
>>     depends on DEBUGGER && !KGDB

> It did not seem that you can make a radio button / multi-select kernel 
> config option unless the options are in the same Kconfig file.  Given 
> that xmon and kgdb are mutually exclusive at the moment.

> What Sergei mentioned is the fix that needs to be used for the time being.
> Attached is the patch I put in the for_mm branch in the linux-2.6-kgdb 
> git tree.

> Jason.

> ------------------------------------------------------------------------

> xmon_or_kgdb.patch

> From: Jason Wessel <jason.wessel@windriver.com>
> Subject: [PATCH] Turn off xmon if kgdb is active on ppc and powerpc

> Xmon and kgdb are mutuall exclusive at the moment so xmon should be
> turned off in the kernel config options if kgdb selected.  The case with "make allmodconfig" was failing and this patch addresses the problem.

> Signed-off-by: Jason Wessel <jason.wessel@windriver.com>

> ---
>  arch/powerpc/Kconfig.debug |    2 +-
>  arch/ppc/Kconfig.debug     |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

    This patch does not seem complete as the #error that was tiggering has not 
been deleleted from arch/powerpc/kernel/kgdb.c (and not it's useless)

WBR, Sergei

Re: 2.6.22-rc6-mm1

[Jason Wessel]

Sergei Shtylyov wrote:
> Hello.
>
> Jason Wessel wrote:
>
>>>>     allmodconfig on powerpc (iMac g3) fails due to
>>>> git-kgdb.patch. allmodconfig defaults should be changed?
>
>>>>   CC      arch/powerpc/kernel/kgdb.o
>>>> arch/powerpc/kernel/kgdb.c:485:2: error: #error Both XMON and KGDB 
>>>> selected in .config. Unselect one of them.
>>>> make[1]: *** [arch/powerpc/kernel/kgdb.o] Blad 1
>>>> make: *** [arch/powerpc/kernel] Blad 2
>
>    This patch does not seem complete as the #error that was tiggering 
> has not been deleleted from arch/powerpc/kernel/kgdb.c (and not it's 
> useless)
>

I suppose the argument could be made to remove the check in the compiled 
file, but it does serve as a way to protect kgdb for now if someone 
tries to hard compile in xmon and kgdb.  Completely unpredictable 
results will occur with the debugger unless some pieces are fixed.  I 
would rather make sure until that happens there is no way head down the 
rat hole.

That issue aside would it be useful to have xmon+kgdb?  After having 
looked at the hook points for xmon, if a command was added to xmon to 
provide an "detach" it would be easy enough to have kgdb and xmon in the 
same kernel.  Obviously only one or the other can be used at any given time.

Jason.

Re: 2.6.22-rc6-mm1

[Paul Mackerras]

Jason Wessel writes:

> I suppose the argument could be made to remove the check in the compiled 
> file, but it does serve as a way to protect kgdb for now if someone 
> tries to hard compile in xmon and kgdb.  Completely unpredictable 
> results will occur with the debugger unless some pieces are fixed.  I 
> would rather make sure until that happens there is no way head down the 
> rat hole.

It should all work provided kgdb plays nicely.  We used to be able to
compile in both xmon and kdb and select at runtime which one gets
used.

> That issue aside would it be useful to have xmon+kgdb?  After having 
> looked at the hook points for xmon, if a command was added to xmon to 
> provide an "detach" it would be easy enough to have kgdb and xmon in the 
> same kernel.  Obviously only one or the other can be used at any given time.

Well, xmon_init(0) will do a detach.  However, I don't see that it is
needed; there is plenty of flexibility to choose to have xmon or not
using the CONFIG_XMON_DEFAULT config option and the xmon= boot command
line option.

Paul.

Re: 2.6.22-rc6-mm1

[Andrew Morton]

On Fri, 29 Jun 2007 14:32:09 +0200
Mariusz Kozlowski <m.kozlowski@tuxland.pl> wrote:

> Hello,
> 
> 	allmodconfig on powerpc (iMac g3) fails due to
> git-kgdb.patch. allmodconfig defaults should be changed?
> 
>   CC      arch/powerpc/kernel/kgdb.o
> arch/powerpc/kernel/kgdb.c:485:2: error: #error Both XMON and KGDB selected 
> in .config. Unselect one of them.
> make[1]: *** [arch/powerpc/kernel/kgdb.o] Blad 1
> make: *** [arch/powerpc/kernel] Blad 2

Jason cc'ed

> anyway after unselecting XMON we can see:
> 
>   CC [M]  fs/xfs/linux-2.6/xfs_ioctl32.o
> fs/xfs/linux-2.6/xfs_ioctl32.c: In function 'xfs_ioc_bulkstat_compat':
> fs/xfs/linux-2.6/xfs_ioctl32.c:334: error: 'xfs_inumbers_fmt_compat' 
> undeclared (first use in this function)
> fs/xfs/linux-2.6/xfs_ioctl32.c:334: error: (Each undeclared identifier is 
> reported only once
> fs/xfs/linux-2.6/xfs_ioctl32.c:334: error: for each function it appears in.)
> make[2]: *** [fs/xfs/linux-2.6/xfs_ioctl32.o] Blad 1
> make[1]: *** [fs/xfs] Blad 2
> 
> This is just allmodconfig - not a .config that's used daily by users but I'm 
> used to compiling the kernel using it anyway 8)
> 

Michal cc'ed.  I think this is the one which was already reported but
I haven't seen a fix yet?

Re: 2.6.22-rc6-mm1

[Michal Marek]

Andrew Morton wrote:
> On Fri, 29 Jun 2007 14:32:09 +0200
> Mariusz Kozlowski <m.kozlowski@tuxland.pl> wrote:
>> anyway after unselecting XMON we can see:
>>
>>   CC [M]  fs/xfs/linux-2.6/xfs_ioctl32.o
>> fs/xfs/linux-2.6/xfs_ioctl32.c: In function 'xfs_ioc_bulkstat_compat':
>> fs/xfs/linux-2.6/xfs_ioctl32.c:334: error: 'xfs_inumbers_fmt_compat' 
>> undeclared (first use in this function)
>> fs/xfs/linux-2.6/xfs_ioctl32.c:334: error: (Each undeclared identifier is 
>> reported only once
>> fs/xfs/linux-2.6/xfs_ioctl32.c:334: error: for each function it appears in.)
>> make[2]: *** [fs/xfs/linux-2.6/xfs_ioctl32.o] Blad 1
>> make[1]: *** [fs/xfs] Blad 2
> 
> Michal cc'ed.  I think this is the one which was already reported but
> I haven't seen a fix yet?

Hi, I sent you an updated patch yesterday (should I've changed the
subject / started a new thread? This was my first patch so bear with
me... :)). Anyway, the mail with the fix is here:
http://lkml.org/lkml/2007/6/29/87

Michal