From: Scott Wood <scottwood@freescale.com>
To: linuxppc-dev@ozlabs.org
Subject: Should of_device_is_compatible() use strcmp() rather than strncasecmp()?
Date: Tue, 03 Jul 2007 16:27:38 -0500 [thread overview]
Message-ID: <468ABF4A.60001@freescale.com> (raw)
Is there any particular reason that of_device_is_compatible uses
strncasecmp()? Besides the OF spec saying that names (and thus
compatibles) are case sensitive, the "n" part screws up matching when a
subset of a string is not a more generic version thereof. For example,
ucc_geth v. ucc_geth_phy, or fsl,cpm v. fsl,cpm-enet.
Does anything actually rely on this behavior?
-Scott
next reply other threads:[~2007-07-03 21:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-03 21:27 Scott Wood [this message]
2007-07-03 21:54 ` Should of_device_is_compatible() use strcmp() rather than strncasecmp()? Segher Boessenkool
2007-07-03 22:15 ` Scott Wood
2007-07-03 22:36 ` Olof Johansson
2007-07-03 22:33 ` Scott Wood
2007-07-03 22:52 ` Segher Boessenkool
2007-07-03 22:41 ` Segher Boessenkool
2007-07-04 3:28 ` Paul Mackerras
2007-07-04 12:09 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468ABF4A.60001@freescale.com \
--to=scottwood@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).