linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* Minor: Removed double return.
@ 2007-07-06 21:59 Manish Ahuja
  2007-07-06 22:58 ` [PATCH] pseries: " Linas Vepstas
  0 siblings, 1 reply; 3+ messages in thread
From: Manish Ahuja @ 2007-07-06 21:59 UTC (permalink / raw)
  To: ppc-dev

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

Found 2 instances of return one right after each other in 
arch_add_memory(). This minor patch fixes it.
Signed-off-by:Manish Ahuja <mahuja@us.ibm.com>



[-- Attachment #2: double-return --]
[-- Type: text/plain, Size: 382 bytes --]

Index: 2.6.22-rc4/arch/powerpc/mm/mem.c
===================================================================
--- 2.6.22-rc4.orig/arch/powerpc/mm/mem.c	2007-06-11 21:10:46.000000000 -0500
+++ 2.6.22-rc4/arch/powerpc/mm/mem.c	2007-06-29 22:52:42.000000000 -0500
@@ -129,8 +129,6 @@
 	zone = pgdata->node_zones;
 
 	return __add_pages(zone, start_pfn, nr_pages);
-
-	return 0;
 }
 
 /*

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] pseries: Re: Minor: Removed double return.
  2007-07-06 21:59 Minor: Removed double return Manish Ahuja
@ 2007-07-06 22:58 ` Linas Vepstas
  2007-07-07 20:26   ` Manish Ahuja
  0 siblings, 1 reply; 3+ messages in thread
From: Linas Vepstas @ 2007-07-06 22:58 UTC (permalink / raw)
  To: Manish Ahuja; +Cc: ppc-dev


You want to say its a patch in the subject line.

--linas

On Fri, Jul 06, 2007 at 04:59:55PM -0500, Manish Ahuja wrote:
> Found 2 instances of return one right after each other in 
> arch_add_memory(). This minor patch fixes it.
> Signed-off-by:Manish Ahuja <mahuja@us.ibm.com>
> 
> 

> Index: 2.6.22-rc4/arch/powerpc/mm/mem.c
> ===================================================================
> --- 2.6.22-rc4.orig/arch/powerpc/mm/mem.c	2007-06-11 21:10:46.000000000 -0500
> +++ 2.6.22-rc4/arch/powerpc/mm/mem.c	2007-06-29 22:52:42.000000000 -0500
> @@ -129,8 +129,6 @@
>  	zone = pgdata->node_zones;
>  
>  	return __add_pages(zone, start_pfn, nr_pages);
> -
> -	return 0;
>  }
>  
>  /*

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pseries: Re: Minor: Removed double return.
  2007-07-06 22:58 ` [PATCH] pseries: " Linas Vepstas
@ 2007-07-07 20:26   ` Manish Ahuja
  0 siblings, 0 replies; 3+ messages in thread
From: Manish Ahuja @ 2007-07-07 20:26 UTC (permalink / raw)
  To: Linas Vepstas; +Cc: ppc-dev

Ah yes, my mistake. Does it require a repost then ?

Thanks,
Manish

Linas Vepstas wrote:
> You want to say its a patch in the subject line.
>
> --linas
>
> On Fri, Jul 06, 2007 at 04:59:55PM -0500, Manish Ahuja wrote:
>   
>> Found 2 instances of return one right after each other in 
>> arch_add_memory(). This minor patch fixes it.
>> Signed-off-by:Manish Ahuja <mahuja@us.ibm.com>
>>
>>
>>     
>
>   
>> Index: 2.6.22-rc4/arch/powerpc/mm/mem.c
>> ===================================================================
>> --- 2.6.22-rc4.orig/arch/powerpc/mm/mem.c	2007-06-11 21:10:46.000000000 -0500
>> +++ 2.6.22-rc4/arch/powerpc/mm/mem.c	2007-06-29 22:52:42.000000000 -0500
>> @@ -129,8 +129,6 @@
>>  	zone = pgdata->node_zones;
>>  
>>  	return __add_pages(zone, start_pfn, nr_pages);
>> -
>> -	return 0;
>>  }
>>  
>>  /*
>>     
>
>   

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-07-07 20:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-06 21:59 Minor: Removed double return Manish Ahuja
2007-07-06 22:58 ` [PATCH] pseries: " Linas Vepstas
2007-07-07 20:26   ` Manish Ahuja

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).