From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
Conor Dooley <conor+dt@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
linux-kernel@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>,
"Aneesh Kumar K.V" <aneesh.kumar@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org, Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 2/5] dt-bindings: hwmon: ibmpowernv: convert to dtschema
Date: Thu, 21 Mar 2024 21:54:25 +0100 [thread overview]
Message-ID: <469068f9-b219-4d80-bab4-cbffaa04a67d@gmail.com> (raw)
In-Reply-To: <171105391076.2619280.17497439995032037227.robh@kernel.org>
On 3/21/24 21:45, Rob Herring wrote:
>
> On Thu, 21 Mar 2024 19:43:43 +0100, Javier Carrasco wrote:
>> Convert existing binding to support validation.
>>
>> This is a straightforward conversion with now new properties.
>>
>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
>> ---
>> .../devicetree/bindings/hwmon/ibm,powernv.yaml | 37 ++++++++++++++++++++++
>> .../devicetree/bindings/hwmon/ibmpowernv.txt | 23 --------------
>> 2 files changed, 37 insertions(+), 23 deletions(-)
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/hwmon/ibm,powernv.example.dtb: /example-0/sensor: failed to match any schema with compatible: ['st,stts751']
>
Obvious mistake, this compatible belongs to another patch of the series.
Will be fixed for v2.
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240321-hwmon_dtschema-v1-2-96c3810c3930@gmail.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
Best regards,
Javier Carrasco
next prev parent reply other threads:[~2024-03-21 21:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 18:43 [PATCH 0/5] dt-bindings: hwmon: convert multiple devices to dtschema Javier Carrasco
2024-03-21 18:43 ` [PATCH 1/5] dt-bindings: hwmon: as370: convert " Javier Carrasco
2024-03-22 2:11 ` Rob Herring
2024-03-21 18:43 ` [PATCH 2/5] dt-bindings: hwmon: ibmpowernv: " Javier Carrasco
2024-03-21 20:45 ` Rob Herring
2024-03-21 20:54 ` Javier Carrasco [this message]
2024-03-21 18:43 ` [PATCH 3/5] dt-bindings: hwmon: pwm-fan: drop text file Javier Carrasco
2024-03-22 2:11 ` Rob Herring
2024-03-21 18:43 ` [PATCH 4/5] dt-bindings: hwmon: stts751: convert to dtschema Javier Carrasco
2024-03-21 20:45 ` Rob Herring
2024-03-21 18:43 ` [PATCH 5/5] dt-bindings: hwmon: ibm,p8-occ-hwmon: move to trivial devices Javier Carrasco
2024-03-22 2:11 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469068f9-b219-4d80-bab4-cbffaa04a67d@gmail.com \
--to=javier.carrasco.cruz@gmail.com \
--cc=aneesh.kumar@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).