From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.dvmed.net (srv5.dvmed.net [207.36.208.214]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 269BFDDD0C for ; Wed, 11 Jul 2007 03:00:24 +1000 (EST) Message-ID: <4693BB22.5070303@garzik.org> Date: Tue, 10 Jul 2007 13:00:18 -0400 From: Jeff Garzik MIME-Version: 1.0 To: Jan-Bernd Themann Subject: Re: [PATCH 2/2] eHEA: Receive SKB Aggregation References: <200707041209.48658.ossthema@de.ibm.com> In-Reply-To: <200707041209.48658.ossthema@de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: Thomas Klein , Jan-Bernd Themann , netdev , linux-kernel , linux-ppc , Christoph Raisch , Marcus Eder , Stefan Roscher List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Jan-Bernd Themann wrote: > This patch enables the receive side processing to aggregate TCP packets within > the HEA device driver. It analyses the packets already received after an > interrupt arrived and forwards these as chains of SKBs for the same TCP > connection with modified header field. We have seen a lower CPU load and > improved throughput for small numbers of parallel TCP connections. > As this feature is considered as experimental it is switched off by default > and can be activated via a module parameter. > > Some additional security checks have been added since the last posting. > > Signed-off-by: Jan-Bernd Themann as noted in comments, we don't need to recreate this in every driver. do something more generic.