From: Mike Wolf <mjw@linux.vnet.ibm.com>
To: Michael Neuling <mikey@neuling.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: Resend: [PATCH] oprofile support for Power 5++
Date: Tue, 10 Jul 2007 15:11:27 -0500 [thread overview]
Message-ID: <4693E7EF.4020708@linux.vnet.ibm.com> (raw)
In-Reply-To: <14287.1184096639@neuling.org>
Michael Neuling wrote:
>> The patch has not been included and there have been no comments so
>> I'm resending.
>>
>> This patch adds a new oprofile cpu type for Power 5 revision 3 chips.
>> The new name is ppc64/power5++ and is used so that the performance
>> counters can be set up correctly.
>>
>
> Does it make more sense to call this "ppc64/power5+rev3"?
>
This is a change to support new counter setup for oprofile. It may be the
same if there is a revision 4 or 5 etc. So since the internal name was ++
I followed that convention.
> Mikey
>
>
>> Signed-off-by: Mike Wolf <mjw@us.ibm.com>
>>
>> --------
>> linux-2.6.18.ppc64.orig/arch/powerpc/kernel/cputable.c 2006-09-19 22:4
>>
> 2:06.000000000 -0500
>
>> +++ linux-2.6.18.ppc64/arch/powerpc/kernel/cputable.c 2007-06-11 12:29:47.000
>>
> 000000 -0500
>
>> @@ -236,6 +236,21 @@
>> .oprofile_mmcra_sipr = MMCRA_SIPR,
>> .platform = "power5",
>> },
>> + { /* Power5++ */
>> + .pvr_mask = 0xffffff00,
>> + .pvr_value = 0x003b0300,
>> + .cpu_name = "POWER5+ (gs)",
>> + .cpu_features = CPU_FTRS_POWER5,
>> + .cpu_user_features = COMMON_USER_POWER5_PLUS,
>> + .icache_bsize = 128,
>> + .dcache_bsize = 128,
>> + .num_pmcs = 6,
>> + .oprofile_cpu_type = "ppc64/power5++",
>> + .oprofile_type = PPC_OPROFILE_POWER4,
>> + .oprofile_mmcra_sihv = MMCRA_SIHV,
>> + .oprofile_mmcra_sipr = MMCRA_SIPR,
>> + .platform = "power5+",
>> + },
>> { /* Power5 GS */
>> .pvr_mask = 0xffff0000,
>> .pvr_value = 0x003b0000,
>>
>> _______________________________________________
>> Linuxppc-dev mailing list
>> Linuxppc-dev@ozlabs.org
>> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>>
>>
next prev parent reply other threads:[~2007-07-10 20:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-10 18:13 Resend: [PATCH] oprofile support for Power 5++ Mike Wolf
2007-07-10 19:43 ` Michael Neuling
2007-07-10 20:11 ` Mike Wolf [this message]
2007-07-10 20:31 ` Michael Neuling
2007-07-10 21:07 ` Will Schmidt
2007-07-10 21:33 ` Maynard Johnson
2007-07-11 20:51 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4693E7EF.4020708@linux.vnet.ibm.com \
--to=mjw@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).