From: Scott Wood <scottwood@freescale.com>
To: Laurent Pinchart <laurent.pinchart@technotrade.biz>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH] [POWERPC] Move generic MPC82xx functions out of ADS-specific
Date: Wed, 11 Jul 2007 10:25:33 -0500 [thread overview]
Message-ID: <4694F66D.2010907@freescale.com> (raw)
In-Reply-To: <200707110928.55339.laurent.pinchart@technotrade.biz>
Laurent Pinchart wrote:
> On Tuesday 10 July 2007 20:05, Scott Wood wrote:
>>Why are you also moving mpc82xx_ads_show_cpuinfo() to the board file?
>>It's not really ADS-specific; it should just be renamed.
>
>
> For the MPC82xx ADS boards, mpc82xx_ads_show_cpuinfo() prints
>
> Vendor : Freescale Semiconductor
> Machine : PQ2 ADS PowerPC
>
> The vendor string is hardcoded to "Freescale Semiconductor", and the machine
> string is defined in pq2ads.h. What should show_cpuinfo() print ? Should the
> vendor be the board vendor or the CPU vendor ? What about the machine ?
Ah, I missed that. I'd just get rid of "Vendor" altogether, and include
the vendor name in the machine name.
-Scott
next prev parent reply other threads:[~2007-07-11 15:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-10 11:12 [PATCH] [POWERPC] Move generic MPC82xx functions out of ADS-specific Laurent Pinchart
2007-07-10 18:05 ` Scott Wood
2007-07-11 7:28 ` Laurent Pinchart
2007-07-11 15:25 ` Scott Wood [this message]
2007-07-12 14:57 ` Laurent Pinchart
2007-07-12 15:04 ` Laurent Pinchart
2007-07-12 23:59 ` Arnd Bergmann
2007-07-12 15:07 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4694F66D.2010907@freescale.com \
--to=scottwood@freescale.com \
--cc=laurent.pinchart@technotrade.biz \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).