From: Scott Wood <scottwood@freescale.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH 1/4] Add DMA sector to Documentation/powerpc/booting-without-of.txt file.
Date: Wed, 11 Jul 2007 10:30:42 -0500 [thread overview]
Message-ID: <4694F7A2.6040403@freescale.com> (raw)
In-Reply-To: <22488704-4826-413B-BD18-F75C2743FB5B@kernel.crashing.org>
Segher Boessenkool wrote:
>> Some hardware has DMA channels hardwired to certain peripherals, such as
>> an audio codec. This keeps them from being used as general purpose DMA
>> channels.
>
>
> I think you need this knowledge in the kernel drivers anyway,
> or at the very least, the device node for for example that
> audio codec needs to refer to the DMA channel in the device
> tree, so this "reserved" property is unnecessary.
The generic DMA driver needs to know not to touch the reserved channels.
>> I'd rather just treat the different DMA channels as independent devices,
>> rather than children of a dma "bus", and change the compatible name if
>> they're not general purpose. There's only one register that's shared
>> among the channels, and it's a superfluous status summary register.
>
> If you make separate nodes for the channels, they need to have
> a parent. I don't think it makes sense to have the channel
> nodes and the "master" node as siblings -- maybe it all should
> be just one node with a "#channels" property or such?
I don't see the need for a master node -- there are no shared registers
(other than a redundant read-only status summary register) to
synchronize access to. Each channel would be an independent device
under the SoC bus.
The benefit is that if a channel needs to be driven by (for example) a
sound driver, it can have a different compatible that will be matched by
the sound driver, and the generic DMA driver will never see it unless
the sound driver explicitly chooses to make use of the generic DMA code
-- and most of the time I think it'd be simpler for the special-purpose
driver to manage the descriptors itself.
-Scott
next prev parent reply other threads:[~2007-07-11 15:30 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-10 9:44 [PATCH 0/4] DMA engine driver for Freescale MPC8xxx processor Zhang Wei
2007-07-10 9:44 ` [PATCH 1/4] Add DMA sector to Documentation/powerpc/booting-without-of.txt file Zhang Wei
2007-07-10 9:44 ` [PATCH 2/4] Add dma sector to mpc8641hpcn board dts Zhang Wei
2007-07-10 13:55 ` Segher Boessenkool
2007-07-11 7:16 ` Zhang Wei-r63237
2007-07-11 11:27 ` Segher Boessenkool
2007-07-12 9:51 ` Zhang Wei-r63237
2007-07-10 13:57 ` Segher Boessenkool
2007-07-11 7:17 ` Zhang Wei-r63237
2007-07-10 14:01 ` [PATCH 1/4] Add DMA sector to Documentation/powerpc/booting-without-of.txt file Segher Boessenkool
2007-07-10 16:11 ` Scott Wood
2007-07-11 10:00 ` Zhang Wei-r63237
2007-07-11 15:23 ` Scott Wood
2007-07-11 17:53 ` Segher Boessenkool
2007-07-12 9:48 ` Zhang Wei-r63237
2007-07-12 17:12 ` Phil Terry
2007-07-12 19:10 ` Scott Wood
2007-07-16 14:56 ` Segher Boessenkool
2007-07-16 14:54 ` Segher Boessenkool
2007-07-17 11:17 ` Paul Mackerras
2007-07-17 15:36 ` Segher Boessenkool
2007-07-11 11:18 ` Segher Boessenkool
2007-07-11 15:30 ` Scott Wood [this message]
2007-07-11 18:01 ` Segher Boessenkool
2007-07-11 18:18 ` Scott Wood
2007-07-11 18:43 ` Segher Boessenkool
2007-07-11 19:03 ` Scott Wood
2007-07-11 19:19 ` Segher Boessenkool
2007-07-11 19:27 ` Scott Wood
2007-07-11 20:27 ` Segher Boessenkool
2007-07-11 10:06 ` Zhang Wei-r63237
2007-07-11 11:40 ` Segher Boessenkool
2007-07-12 9:45 ` Zhang Wei-r63237
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4694F7A2.6040403@freescale.com \
--to=scottwood@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).