From: Scott Wood <scottwood@freescale.com>
To: Alexandre Bounine <Alexandre.Bounine@tundra.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Fix Tsi108 ethernet driver performance
Date: Fri, 13 Jul 2007 15:28:59 -0500 [thread overview]
Message-ID: <4697E08B.6080700@freescale.com> (raw)
In-Reply-To: <1B5F013528140F45B5C671039279CA5701F8314C@NANUK.pc.tundra.com>
Alexandre Bounine wrote:
> -/* If the RX ring has run out of memory, try periodically
> - * to allocate some more, as otherwise poll would never
> - * get called (apart from the initial end-of-queue condition).
> - *
> - * This is called once per second (by default) from the thread.
> +/* tsi108_check_rxring() is used to periodically check if the RX ring
> has
> + * pending frames that have not been reported by RX interrupt (due to
> interrupt
> + * moderation). It is called with CHECK_RX_INTERVAL timer interval.
Wouldn't this cause latencies of up to a second in responding to
received packets? I'd think that would be considered excessive.
And shouldn't NAPI be reducing the RX interrupt load anyway?
-Scott
next prev parent reply other threads:[~2007-07-13 20:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 20:00 [PATCH] Fix Tsi108 ethernet driver performance Alexandre Bounine
2007-07-13 20:28 ` Scott Wood [this message]
2007-07-13 20:32 ` Scott Wood
2007-07-16 17:25 ` Alexandre Bounine
-- strict thread matches above, loose matches on Subject: below --
2007-07-16 17:36 Alexandre Bounine
2007-07-16 22:27 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4697E08B.6080700@freescale.com \
--to=scottwood@freescale.com \
--cc=Alexandre.Bounine@tundra.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).