From: Scott Wood <scottwood@freescale.com>
To: Milton Miller <miltonm@bga.com>
Cc: ppcdev <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 10/61] bootwrapper: flatdevtree fixes
Date: Wed, 18 Jul 2007 13:56:01 -0500 [thread overview]
Message-ID: <469E6241.5090604@freescale.com> (raw)
In-Reply-To: <9b26986bc99c74c5e17e08191eb07d67@bga.com>
Milton Miller wrote:
> In-Reply-To: <20070718013137.GA15217@ld0162-tx32.am.freescale.net>
>
> On Wed Jul 18 11:33:08 EST 2007, Scott Wood wrote:
>
>> 1. ft_create_node was returning the internal pointer rather than a
>> phandle.
>> 2. ft_find_device_rel was treating lookups relative to root as an error.
>
>
> No, it is treating lookups relative to NULL as an error.
>
> Your patch changes it to treat lookups relative to the NULL phandle as
> relative to root.
Other parts of the code (such as ft_create_node) already do that.
What's wrong with it?
> I've no objections to the other part, can you split these?
No, because change #1 won't work without change #2.
-Scott
next prev parent reply other threads:[~2007-07-18 18:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-18 15:43 [PATCH 10/61] bootwrapper: flatdevtree fixes Milton Miller
2007-07-18 18:56 ` Scott Wood [this message]
2007-07-19 5:45 ` Milton Miller
-- strict thread matches above, loose matches on Subject: below --
2007-07-18 1:31 [PATCH 01/61] Use strcasecmp() rather than strncasecmp() when determining device node compatibility Scott Wood
2007-07-18 1:33 ` [PATCH 10/61] bootwrapper: flatdevtree fixes Scott Wood
2007-07-18 16:20 ` Milton Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469E6241.5090604@freescale.com \
--to=scottwood@freescale.com \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=miltonm@bga.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).