From: Jerry Van Baren <gvb.linuxppc.dev@gmail.com>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.com
Subject: Re: [PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path
Date: Thu, 19 Jul 2007 22:00:19 -0400 [thread overview]
Message-ID: <46A01733.6080609@gmail.com> (raw)
In-Reply-To: <469FDB3B.5000901@freescale.com>
Scott Wood wrote:
> Kim Phillips wrote:
>> the old FLAT_TREE u-boot fdt fixup code renames any existing chosen
>> node out of the way, and adds its fixed up version as /chosen.
Not in my experience. My experience is that it blindly created a second
/chosen node.
>> The LIBFDT implementation replaces any existing /chosen with its fixed
>> up version.
Sort of. If /chosen doesn't exist, it creates it.
If /chosen exists and "force" parameter is false, it doesn't touch it.
If "force" is true, it creates or fixes up properties. The "bootm"
command passes in force == false. The "fdt" command passes in force ==
true.
The "force" parameter was added to sort of emulate the previous bootm
command behavior (but behave better in the case where /chosen already
existed).
Such is the price for not totally breaking user expectations. Hopefully
we recalibrate user expectations in the future and improve this.
> Could you point out the code that does this? I don't see it in either
> the old code or the new.
>
> -Scott
Old code - I don't think so.
New code...
u-boot-fdt repo:
<http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot/u-boot-fdt.git;a=blob;f=common/fdt_support.c;h=259bd42cc62c55d11370579a7af0d6519fc34c8d;hb=01f771763ed822145b54819abb9c4516c8216d48#l96>
u-boot repo:
<http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=blob;f=common/fdt_support.c;h=69099c4275ccb925cce7b7c69afc5ab4f76cfe6f;hb=HEAD#l92>
Hope this makes sense,
gvb
next prev parent reply other threads:[~2007-07-20 2:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 18:34 [PATCH 0/4] Series short description grant.likely
2007-07-19 18:37 ` [PATCH 1/4] bootwrapper: In cuImage, print message for ENET devices not found in tree Grant Likely
2007-07-19 18:37 ` [PATCH 2/4] mpc8349: Add linux,network-index to ethernet nodes in device tree Grant Likely
2007-07-19 18:37 ` [PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path Grant Likely
2007-07-19 18:59 ` Scott Wood
2007-07-19 19:43 ` Grant Likely
2007-07-19 19:58 ` Jerry Van Baren
2007-07-19 20:00 ` Grant Likely
2007-07-19 21:40 ` Kim Phillips
2007-07-19 21:44 ` Scott Wood
2007-07-19 22:28 ` Kim Phillips
2007-07-20 2:00 ` Jerry Van Baren [this message]
2007-07-20 16:14 ` Scott Wood
2007-07-20 16:46 ` Jerry Van Baren
2007-07-23 13:12 ` Timur Tabi
2007-07-19 22:12 ` Grant Likely
2007-07-19 18:37 ` [PATCH 4/4] mpc8349emitx(gp): update defconfigs for 2.6.23 Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A01733.6080609@gmail.com \
--to=gvb.linuxppc.dev@gmail.com \
--cc=linuxppc-dev@ozlabs.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).