Someone broke my allmodconfig build

Someone broke my allmodconfig build

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1123 bytes --]

Hi all,

At the end of a powerpc allmodconfig build, I get this (after the header
checks):

  LD      vmlinux
  SYSMAP  System.map
  SYSMAP  .tmp_System.map
strip -s -R .comment vmlinux -o vmlinux.strip
strip -s -R .comment vmlinux -o arch/powerpc/boot/zImage.iseries
  WRAP    arch/powerpc/boot/zImage.pseries
  WRAP    arch/powerpc/boot/zImage.pmac
  WRAP    arch/powerpc/boot/zImage.ps3
/home/sfr/kernels/linus/arch/powerpc/boot/wrapper: line 113: dtc: command not found
make[2]: *** [arch/powerpc/boot/zImage.ps3] Error 1
make[2]: *** Waiting for unfinished jobs....
  Building modules, stage 2.
make[1]: *** [zImage] Error 2
make[1]: *** Waiting for unfinished jobs....
  MODPOST 1794 modules
ERROR: "pmu_batteries" [drivers/power/pmu_battery.ko] undefined!
ERROR: "pmu_battery_count" [drivers/power/pmu_battery.ko] undefined!
ERROR: "pmu_power_flags" [drivers/power/pmu_battery.ko] undefined!
make[2]: *** [__modpost] Error 1
make[1]: *** [modules] Error 2
make: *** [_all] Error 2

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: Someone broke my allmodconfig build

[Paul Mackerras]

Stephen Rothwell writes:

>   WRAP    arch/powerpc/boot/zImage.ps3
> /home/sfr/kernels/linus/arch/powerpc/boot/wrapper: line 113: dtc: command not found
> make[2]: *** [arch/powerpc/boot/zImage.ps3] Error 1

Hmmm, we should be shipping .dtb files with the tree, so people don't
have to have dtc installed.

> ERROR: "pmu_batteries" [drivers/power/pmu_battery.ko] undefined!
> ERROR: "pmu_battery_count" [drivers/power/pmu_battery.ko] undefined!
> ERROR: "pmu_power_flags" [drivers/power/pmu_battery.ko] undefined!

I'd say CONFIG_BATTERY_PMU needs to depend on PPC32.  There are no
battery-powered ppc64 machines with an Apple PMU, and we can say
pretty confidently there never will be.

Paul.

Re: Someone broke my allmodconfig build

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 557 bytes --]

On Sun, 22 Jul 2007 10:37:06 +1000 Paul Mackerras <paulus@samba.org> wrote:
>
> Stephen Rothwell writes:
> 
> >   WRAP    arch/powerpc/boot/zImage.ps3
> > /home/sfr/kernels/linus/arch/powerpc/boot/wrapper: line 113: dtc: command not found
> > make[2]: *** [arch/powerpc/boot/zImage.ps3] Error 1
> 
> Hmmm, we should be shipping .dtb files with the tree, so people don't
> have to have dtc installed.

Unless, of course, we ship dtc ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: Someone broke my allmodconfig build

[Josh Boyer]

On Sun, Jul 22, 2007 at 10:37:06AM +1000, Paul Mackerras wrote:
> Stephen Rothwell writes:
> 
> >   WRAP    arch/powerpc/boot/zImage.ps3
> > /home/sfr/kernels/linus/arch/powerpc/boot/wrapper: line 113: dtc: command not found
> > make[2]: *** [arch/powerpc/boot/zImage.ps3] Error 1
> 
> Hmmm, we should be shipping .dtb files with the tree, so people don't
> have to have dtc installed.

Really?  I don't think we're quite ready for that.  Particularly for the
embedded boards.  Those DTS files still get lots of churn, and having to
update both the .dts and .dtb at the same time seems a bit fragile.

josh

Re: Someone broke my allmodconfig build

[David Gibson]

On Sat, Jul 21, 2007 at 09:04:13PM -0500, Josh Boyer wrote:
> On Sun, Jul 22, 2007 at 10:37:06AM +1000, Paul Mackerras wrote:
> > Stephen Rothwell writes:
> > 
> > >   WRAP    arch/powerpc/boot/zImage.ps3
> > > /home/sfr/kernels/linus/arch/powerpc/boot/wrapper: line 113: dtc: command not found
> > > make[2]: *** [arch/powerpc/boot/zImage.ps3] Error 1
> > 
> > Hmmm, we should be shipping .dtb files with the tree, so people don't
> > have to have dtc installed.
> 
> Really?  I don't think we're quite ready for that.  Particularly for the
> embedded boards.  Those DTS files still get lots of churn, and having to
> update both the .dts and .dtb at the same time seems a bit fragile.

I sort of prefer this option in theory, but it's basically
impossible.  People updating dts files by patch would also have to
update the dtb, which can't be done in a normal patch, since they're
binary.

I'm working with sfr now on importing dtc into the kernel tree.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: Someone broke my allmodconfig build

[Timur Tabi]

Stephen Rothwell wrote:

>> Hmmm, we should be shipping .dtb files with the tree, so people don't
>> have to have dtc installed.
> 
> Unless, of course, we ship dtc ...

I like that idea.

I don't know much about the kernel build process, but is it normal to ship C files and have kbuild build them and then use the executables to build the rest of the kernel?

Re: Someone broke my allmodconfig build

[Grant Likely]

On 7/23/07, Timur Tabi <timur@freescale.com> wrote:
> Stephen Rothwell wrote:
>
> >> Hmmm, we should be shipping .dtb files with the tree, so people don't
> >> have to have dtc installed.
> >
> > Unless, of course, we ship dtc ...
>
> I like that idea.
>
> I don't know much about the kernel build process, but is it normal to ship C files and have kbuild build them and then use the executables to build the rest of the kernel?

That's how Kconfig is built.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195

Re: Someone broke my allmodconfig build

[Josh Boyer]

On Mon, 2007-07-23 at 09:07 -0600, Grant Likely wrote:
> On 7/23/07, Timur Tabi <timur@freescale.com> wrote:
> > Stephen Rothwell wrote:
> >
> > >> Hmmm, we should be shipping .dtb files with the tree, so people don't
> > >> have to have dtc installed.
> > >
> > > Unless, of course, we ship dtc ...
> >
> > I like that idea.
> >
> > I don't know much about the kernel build process, but is it normal to ship C files and have kbuild build them and then use the executables to build the rest of the kernel?
> 
> That's how Kconfig is built.

And mktree.

josh

Re: Someone broke my allmodconfig build

[Mark A. Greer]

On Mon, Jul 23, 2007 at 11:43:37AM +1000, David Gibson wrote:
> On Sat, Jul 21, 2007 at 09:04:13PM -0500, Josh Boyer wrote:
> > On Sun, Jul 22, 2007 at 10:37:06AM +1000, Paul Mackerras wrote:
> > > Stephen Rothwell writes:
> > > 
> > > >   WRAP    arch/powerpc/boot/zImage.ps3
> > > > /home/sfr/kernels/linus/arch/powerpc/boot/wrapper: line 113: dtc: command not found
> > > > make[2]: *** [arch/powerpc/boot/zImage.ps3] Error 1
> > > 
> > > Hmmm, we should be shipping .dtb files with the tree, so people don't
> > > have to have dtc installed.
> > 
> > Really?  I don't think we're quite ready for that.  Particularly for the
> > embedded boards.  Those DTS files still get lots of churn, and having to
> > update both the .dts and .dtb at the same time seems a bit fragile.
> 
> I sort of prefer this option in theory, but it's basically
> impossible.  People updating dts files by patch would also have to
> update the dtb, which can't be done in a normal patch, since they're
> binary.

I agree.  Shipping a magic binary blob, especially ones that haven't
really settled out, will be a real headache for poeple.

> I'm working with sfr now on importing dtc into the kernel tree.

IIRC, this was discussed when dtc first came into existence but it was
pooh-poohed.  I forget why now.

Mark

Re: Someone broke my allmodconfig build

[Timur Tabi]

Grant Likely wrote:
> On 7/23/07, Timur Tabi <timur@freescale.com> wrote:
>> Stephen Rothwell wrote:
>>
>> >> Hmmm, we should be shipping .dtb files with the tree, so people don't
>> >> have to have dtc installed.
>> >
>> > Unless, of course, we ship dtc ...
>>
>> I like that idea.
>>
>> I don't know much about the kernel build process, but is it normal to 
>> ship C files and have kbuild build them and then use the executables 
>> to build the rest of the kernel?
> 
> That's how Kconfig is built.

Then it shouldn't be too hard to refactor the dtc build environment to make it 
Kbuild-compatible, and then Paul can pull from Jon's dtc repo whenever it gets updated.

Jon, what do you think?

-- 
Timur Tabi
Linux Kernel Developer @ Freescale