From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jeff@garzik.org>
Received: from mail.dvmed.net (srv5.dvmed.net [207.36.208.214])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by ozlabs.org (Postfix) with ESMTP id 22EF5DDE9C
	for <linuxppc-dev@ozlabs.org>; Tue, 24 Jul 2007 23:44:33 +1000 (EST)
Message-ID: <46A60235.10107@garzik.org>
Date: Tue, 24 Jul 2007 09:44:21 -0400
From: Jeff Garzik <jeff@garzik.org>
MIME-Version: 1.0
To: Andreas Schwab <schwab@suse.de>
Subject: Re: [patch 1/3] ps3: Disk Storage Driver
References: <20070716161539.075822000@pademelon.sonytel.be>	<20070716162206.392129000@pademelon.sonytel.be>	<20070718163637.3f0e0164.akpm@linux-foundation.org>	<46A5E610.7000508@shadowen.org>
	<46A5F275.7060905@garzik.org> <je3aze6k1b.fsf@sykes.suse.de>
In-Reply-To: <je3aze6k1b.fsf@sykes.suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Cc: Jens Axboe <axboe@kernel.dk>,
	"James E.J. Bottomley" <James.Bottomley@SteelEye.com>,
	linux-scsi@vger.kernel.org, Jens Axboe <jens.axboe@oracle.com>,
	linux-kernel@vger.kernel.org, Alessandro Rubini <rubini@vision.unipv.it>,
	linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
	Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
	Andrew Morton <akpm@linux-foundation.org>
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

Andreas Schwab wrote:
> Jeff Garzik <jeff@garzik.org> writes:
> 
>> Andy Whitcroft wrote:
>>> Andrew Morton wrote:
>>>
>>>>> +	start_sector = req->sector*priv->blocking_factor;
>>>>> +	sectors = req->nr_sectors*priv->blocking_factor;
>>>> s/*/ * /.  checkpatch missed this.
>>> Ok, this is something we need to decide on.  Currently we only ask for
>>> consistent spacing on all the mathematic operators.  This is mostly as
>>> we do see a large number of non-spaced uses in defines and the like.
>>>
>>> I am happy to expand these tests so they are always spaced on both sides
>>> style if that is the preference.
>> That is most definitely the preference:  spaces surround operators.
>                                                           ^binary

Yes.  :)

	Jeff