From: Scott Wood <scottwood@freescale.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org
Subject: Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface
Date: Wed, 25 Jul 2007 13:46:57 -0500 [thread overview]
Message-ID: <46A79AA1.3030608@freescale.com> (raw)
In-Reply-To: <46A7968D.3070707@ru.mvista.com>
Sergei Shtylyov wrote:
> I acn undertand your complaint in the context of an OF driver (which
> we don't have yet) but "mmio-ide" just means nothing to the current
> driver, and it doesn't convery enough info on the programming interface
> for the conceivable OF driver, it also does need to know at least
> "reg-stride" (and maybe "reg-size" in case only 16/32-bit accesses can
> be used). Well, if such driver will be written, I/O mapping support
> will probably be dropped from it, so indeed, calling it mmio-ide.c would
> make sense. But that can be added when this driver is done, and for now
I don't think the details of what Linux code currently exists should
drive the device tree binding. That the current patches use
platform_device glue code is an implementation detail (and one I'd
rather see go away, in favor of a driver that supports both
platform_device and of_device).
> I'd really prefer the board name to appear in the "compatible" prop (to
> which "mmio-ide" can be appended)...
Sure, that's always good... it was the "instead" that I objected to.
-Scott
next prev parent reply other threads:[~2007-07-25 18:47 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 16:53 [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver) Vitaly Bordug
2007-07-25 16:53 ` [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface Vitaly Bordug
2007-07-25 17:06 ` Sergei Shtylyov
2007-07-25 17:54 ` Sergei Shtylyov
2007-07-25 18:01 ` Scott Wood
2007-07-25 18:19 ` Sergei Shtylyov
2007-07-25 18:39 ` Scott Wood
2007-07-25 19:30 ` Sergei Shtylyov
2007-07-26 16:24 ` Sergei Shtylyov
2007-07-31 22:47 ` Segher Boessenkool
2007-07-25 18:29 ` Sergei Shtylyov
2007-07-25 18:46 ` Scott Wood [this message]
2007-07-26 17:21 ` Vitaly Bordug
2007-07-26 17:45 ` Sergei Shtylyov
2007-07-31 22:36 ` Segher Boessenkool
2007-07-31 23:56 ` Alan Cox
2007-08-06 17:19 ` Segher Boessenkool
2007-08-01 13:11 ` Sergei Shtylyov
2007-07-26 17:12 ` Vitaly Bordug
2007-07-25 17:29 ` Scott Wood
2007-07-25 17:43 ` [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver) Alan Cox
2007-07-26 19:28 ` Bartlomiej Zolnierkiewicz
2007-07-25 17:59 ` Kumar Gala
2007-07-25 19:00 ` Sergei Shtylyov
2007-07-25 19:05 ` Scott Wood
2007-07-25 19:16 ` Sergei Shtylyov
2007-07-25 19:17 ` [PATCH 1/2] [IDE] Platform IDE driver Scott Wood
2007-07-25 19:35 ` Sergei Shtylyov
2007-07-31 22:31 ` Segher Boessenkool
2007-08-01 12:39 ` Sergei Shtylyov
2007-08-06 17:16 ` Segher Boessenkool
2007-07-25 19:37 ` [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver) Guennadi Liakhovetski
2007-07-25 19:48 ` Sergei Shtylyov
2007-07-25 19:54 ` Guennadi Liakhovetski
2007-07-25 20:01 ` Sergei Shtylyov
2007-07-25 20:09 ` Guennadi Liakhovetski
2007-07-25 20:39 ` Alan Cox
2007-07-26 19:41 ` Guennadi Liakhovetski
2007-07-26 19:52 ` Sergei Shtylyov
2007-07-26 20:13 ` Guennadi Liakhovetski
2007-07-26 20:11 ` Bartlomiej Zolnierkiewicz
2007-07-26 19:28 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A79AA1.3030608@freescale.com \
--to=scottwood@freescale.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).