From: Jeff Garzik <jeff@garzik.org>
To: Jan-Bernd Themann <ossthema@de.ibm.com>,
David Miller <davem@davemloft.net>
Cc: Thomas Klein <tklein@de.ibm.com>,
Jan-Bernd Themann <themann@de.ibm.com>,
netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-ppc <linuxppc-dev@ozlabs.org>,
Christoph Raisch <raisch@de.ibm.com>,
Marcus Eder <meder@de.ibm.com>,
Andrew Gallatin <gallatin@myri.com>,
Stefan Roscher <stefan.roscher@de.ibm.com>
Subject: Re: [PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic
Date: Mon, 30 Jul 2007 12:17:58 -0400 [thread overview]
Message-ID: <46AE0F36.8030605@garzik.org> (raw)
In-Reply-To: <200707301724.33865.ossthema@de.ibm.com>
Seems pretty good to me, save for one minor detail: patches #1/#2
should be combined together for greater git-bisect happiness. Ditto for
patches #3/#4. Largely harmless in this case, but keeps the git history
pollution to a minimum.
Caveat reviewer: I'm not an expert of net/ipv4/* code, so I reviewed
largely from the driver API perspective.
David, thoughts on merging? I'm not We could stick this into your tree
or mine. Whether yours or mine, I would like to keep the driver and
net-core patches together in the same git tree.
Jeff
next prev parent reply other threads:[~2007-07-30 16:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-30 15:24 [PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic Jan-Bernd Themann
2007-07-30 16:17 ` Jeff Garzik [this message]
2007-07-30 22:43 ` David Miller
2007-07-31 0:00 ` Jeff Garzik
2007-07-30 17:00 ` Linas Vepstas
2007-07-30 17:43 ` Andrew Gallatin
2007-07-30 19:57 ` Stephen Hemminger
2007-07-31 3:58 ` Leonid Grossman
2007-07-30 20:32 ` Andrew Gallatin
2007-07-31 10:33 ` Jan-Bernd Themann
2007-07-31 13:34 ` Andrew Gallatin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46AE0F36.8030605@garzik.org \
--to=jeff@garzik.org \
--cc=davem@davemloft.net \
--cc=gallatin@myri.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=meder@de.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ossthema@de.ibm.com \
--cc=raisch@de.ibm.com \
--cc=stefan.roscher@de.ibm.com \
--cc=themann@de.ibm.com \
--cc=tklein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).