From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.dvmed.net (srv5.dvmed.net [207.36.208.214]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id DF0D8DDF40 for ; Tue, 31 Jul 2007 02:36:26 +1000 (EST) Message-ID: <46AE1383.3050305@garzik.org> Date: Mon, 30 Jul 2007 12:36:19 -0400 From: Jeff Garzik MIME-Version: 1.0 To: Stephen Hemminger Subject: Re: [PATCH 2/4][RFC] lro: Kconfig and Makefile References: <200707301724.45781.ossthema@de.ibm.com> <20070730172535.15993806@oldman.hamilton.local> In-Reply-To: <20070730172535.15993806@oldman.hamilton.local> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: Thomas Klein , Jan-Bernd Themann , netdev , linux-kernel , Christoph Raisch , linux-ppc , Jan-Bernd Themann , Marcus Eder , Andrew Gallatin , Stefan Roscher , David Miller List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Stephen Hemminger wrote: > Why make this a user selectable option at all? Unless you want > to deal with out of tree drivers (not my problem), it should be hidden > to avoid having to explain an support it. In this case it's an optional library kernel module. That seems to be a common setup for library modules. We do the same with CONFIG_MII and drivers/net/mii.ko as well. Originally it was done purely in the Makefile, but that does not account for net drivers in sub-directories (or out of tree as you point out). Jeff