From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Thomas Klein <tklein@de.ibm.com>,
Jan-Bernd Themann <themann@de.ibm.com>,
Stefan Roscher <stefan.roscher@de.ibm.com>,
netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Christoph Raisch <raisch@de.ibm.com>,
linux-ppc <linuxppc-dev@ozlabs.org>,
Jan-Bernd Themann <ossthema@de.ibm.com>,
Marcus Eder <meder@de.ibm.com>,
Andrew Gallatin <gallatin@myri.com>,
Stephen Hemminger <shemminger@linux-foundation.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH 2/4][RFC] lro: Kconfig and Makefile
Date: Mon, 30 Jul 2007 10:00:30 -0700 [thread overview]
Message-ID: <46AE192E.4080205@intel.com> (raw)
In-Reply-To: <46AE1383.3050305@garzik.org>
Jeff Garzik wrote:
> Stephen Hemminger wrote:
>> Why make this a user selectable option at all? Unless you want
>> to deal with out of tree drivers (not my problem), it should be hidden
>> to avoid having to explain an support it.
>
> In this case it's an optional library kernel module. That seems to be a
> common setup for library modules. We do the same with CONFIG_MII and
> drivers/net/mii.ko as well.
>
> Originally it was done purely in the Makefile, but that does not account
> for net drivers in sub-directories (or out of tree as you point out).
speaking of that, shouldn't there be a NETIF_F_LRO ?
Auke
prev parent reply other threads:[~2007-07-30 17:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-30 15:24 [PATCH 2/4][RFC] lro: Kconfig and Makefile Jan-Bernd Themann
2007-07-30 16:25 ` Stephen Hemminger
2007-07-30 16:36 ` Jeff Garzik
2007-07-30 17:00 ` Kok, Auke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46AE192E.4080205@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=davem@davemloft.net \
--cc=gallatin@myri.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=meder@de.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ossthema@de.ibm.com \
--cc=raisch@de.ibm.com \
--cc=shemminger@linux-foundation.org \
--cc=stefan.roscher@de.ibm.com \
--cc=themann@de.ibm.com \
--cc=tklein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).