* [PATCH 2/4][RFC] lro: Kconfig and Makefile
@ 2007-07-30 15:24 Jan-Bernd Themann
2007-07-30 16:25 ` Stephen Hemminger
0 siblings, 1 reply; 4+ messages in thread
From: Jan-Bernd Themann @ 2007-07-30 15:24 UTC (permalink / raw)
To: netdev
Cc: Thomas Klein, Jeff Garzik, Jan-Bernd Themann, linux-kernel,
linux-ppc, Christoph Raisch, Marcus Eder, Andrew Gallatin,
Stefan Roscher, David Miller
Kconfig and Makefile for LRO
Signed-off-by: Jan-Bernd Themann <themann@de.ibm.com>
---
net/ipv4/Kconfig | 8 ++++++++
net/ipv4/Makefile | 1 +
2 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index fb79097..d894f61 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -394,6 +394,14 @@ config INET_XFRM_MODE_BEET
If unsure, say Y.
+config INET_LRO
+ tristate "Large Receive Offload (ipv4/tcp)"
+
+ ---help---
+ Support for Large Receive Offload (ipv4/tcp).
+
+ If unsure, say Y.
+
config INET_DIAG
tristate "INET: socket monitoring interface"
default y
diff --git a/net/ipv4/Makefile b/net/ipv4/Makefile
index fbf1674..a02c36d 100644
--- a/net/ipv4/Makefile
+++ b/net/ipv4/Makefile
@@ -25,6 +25,7 @@ obj-$(CONFIG_INET_ESP) += esp4.o
obj-$(CONFIG_INET_IPCOMP) += ipcomp.o
obj-$(CONFIG_INET_XFRM_TUNNEL) += xfrm4_tunnel.o
obj-$(CONFIG_INET_XFRM_MODE_BEET) += xfrm4_mode_beet.o
+obj-$(CONFIG_INET_LRO) += inet_lro.o
obj-$(CONFIG_INET_TUNNEL) += tunnel4.o
obj-$(CONFIG_INET_XFRM_MODE_TRANSPORT) += xfrm4_mode_transport.o
obj-$(CONFIG_INET_XFRM_MODE_TUNNEL) += xfrm4_mode_tunnel.o
--
1.5.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/4][RFC] lro: Kconfig and Makefile
2007-07-30 15:24 [PATCH 2/4][RFC] lro: Kconfig and Makefile Jan-Bernd Themann
@ 2007-07-30 16:25 ` Stephen Hemminger
2007-07-30 16:36 ` Jeff Garzik
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2007-07-30 16:25 UTC (permalink / raw)
To: Jan-Bernd Themann
Cc: Thomas Klein, Jeff Garzik, Jan-Bernd Themann, netdev, Stefan,
linux-kernel, linux-ppc, Christoph Raisch, Marcus Eder,
Andrew Gallatin, Roscher, David Miller
On Mon, 30 Jul 2007 17:24:45 +0200
Jan-Bernd Themann <ossthema@de.ibm.com> wrote:
> Kconfig and Makefile for LRO
>
> Signed-off-by: Jan-Bernd Themann <themann@de.ibm.com>
>
> ---
> net/ipv4/Kconfig | 8 ++++++++
> net/ipv4/Makefile | 1 +
> 2 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
> index fb79097..d894f61 100644
> --- a/net/ipv4/Kconfig
> +++ b/net/ipv4/Kconfig
> @@ -394,6 +394,14 @@ config INET_XFRM_MODE_BEET
>
> If unsure, say Y.
>
> +config INET_LRO
> + tristate "Large Receive Offload (ipv4/tcp)"
> +
> + ---help---
> + Support for Large Receive Offload (ipv4/tcp).
> +
> + If unsure, say Y.
> +
Why make this a user selectable option at all? Unless you want
to deal with out of tree drivers (not my problem), it should be hidden
to avoid having to explain an support it.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/4][RFC] lro: Kconfig and Makefile
2007-07-30 16:25 ` Stephen Hemminger
@ 2007-07-30 16:36 ` Jeff Garzik
2007-07-30 17:00 ` Kok, Auke
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Garzik @ 2007-07-30 16:36 UTC (permalink / raw)
To: Stephen Hemminger
Cc: Thomas Klein, Jan-Bernd Themann, netdev, linux-kernel,
Christoph Raisch, linux-ppc, Jan-Bernd Themann, Marcus Eder,
Andrew Gallatin, Stefan Roscher, David Miller
Stephen Hemminger wrote:
> Why make this a user selectable option at all? Unless you want
> to deal with out of tree drivers (not my problem), it should be hidden
> to avoid having to explain an support it.
In this case it's an optional library kernel module. That seems to be a
common setup for library modules. We do the same with CONFIG_MII and
drivers/net/mii.ko as well.
Originally it was done purely in the Makefile, but that does not account
for net drivers in sub-directories (or out of tree as you point out).
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/4][RFC] lro: Kconfig and Makefile
2007-07-30 16:36 ` Jeff Garzik
@ 2007-07-30 17:00 ` Kok, Auke
0 siblings, 0 replies; 4+ messages in thread
From: Kok, Auke @ 2007-07-30 17:00 UTC (permalink / raw)
To: Jeff Garzik
Cc: Thomas Klein, Jan-Bernd Themann, Stefan Roscher, netdev,
linux-kernel, Christoph Raisch, linux-ppc, Jan-Bernd Themann,
Marcus Eder, Andrew Gallatin, Stephen Hemminger, David Miller
Jeff Garzik wrote:
> Stephen Hemminger wrote:
>> Why make this a user selectable option at all? Unless you want
>> to deal with out of tree drivers (not my problem), it should be hidden
>> to avoid having to explain an support it.
>
> In this case it's an optional library kernel module. That seems to be a
> common setup for library modules. We do the same with CONFIG_MII and
> drivers/net/mii.ko as well.
>
> Originally it was done purely in the Makefile, but that does not account
> for net drivers in sub-directories (or out of tree as you point out).
speaking of that, shouldn't there be a NETIF_F_LRO ?
Auke
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-07-30 17:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-30 15:24 [PATCH 2/4][RFC] lro: Kconfig and Makefile Jan-Bernd Themann
2007-07-30 16:25 ` Stephen Hemminger
2007-07-30 16:36 ` Jeff Garzik
2007-07-30 17:00 ` Kok, Auke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).