From: Robert Hancock <hancockr@shaw.ca>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
stable@kernel.org, linux-kernel@vger.kernel.org,
Olaf Hering <olh@suse.de>
Subject: Re: [PATCH 2.6.22.y] ieee1394: revert "sbp2: enforce 32bit DMA mapping"
Date: Mon, 06 Aug 2007 16:35:25 -0600 [thread overview]
Message-ID: <46B7A22D.4030909@shaw.ca> (raw)
In-Reply-To: <1186439529.938.95.camel@localhost.localdomain>
Benjamin Herrenschmidt wrote:
> On Mon, 2007-08-06 at 16:25 -0600, Robert Hancock wrote:
>>> Anyway. For now I will simply go with what 2.6.23-rc has and what
>>> 2.6.21 had: No dma_set_mask anywhere in the 1394 subsystem. We can
>>> revisit this whenever an actual need arises.
>> Not sure this is a very good idea. This seems rather likely to fail on
>> x86_64 machines with >4GB of RAM for example..
>
> Would it ? Isn't the default DMA mask for PCI devices set to 32 bits
> anyway ? In which case, swiotlb will take care of the matter.
>
> Cheers,
> Ben.
Hmm, that's true, yes. Suppose it shouldn't be a problem then.
I would agree, though, that sbp2 isn't really the place for setting
this, since the DMA mask is presently a property of the device, not of
the user..
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/
next prev parent reply other threads:[~2007-08-06 22:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.Qn3Snqoik3hhnxcA6HqjGV0Yzck@ifi.uio.no>
[not found] ` <46B4B3DC.7020609@shaw.ca>
2007-08-04 17:30 ` [PATCH 2.6.22.y] ieee1394: revert "sbp2: enforce 32bit DMA mapping" Stefan Richter
2007-08-05 0:15 ` Benjamin Herrenschmidt
2007-08-05 7:54 ` Stefan Richter
2007-08-05 22:04 ` Benjamin Herrenschmidt
2007-08-06 13:51 ` Olaf Hering
2007-08-06 21:47 ` Benjamin Herrenschmidt
2007-08-06 22:22 ` Stefan Richter
2007-08-06 22:25 ` Robert Hancock
2007-08-06 22:32 ` Benjamin Herrenschmidt
2007-08-06 22:35 ` Robert Hancock [this message]
2007-08-06 22:59 ` Stefan Richter
2007-08-06 22:48 ` Stefan Richter
2007-08-07 2:18 ` Andi Kleen
2007-08-06 22:29 ` Benjamin Herrenschmidt
2007-08-06 11:58 ` Olaf Hering
2007-08-06 21:43 ` Benjamin Herrenschmidt
2007-08-06 22:05 ` [PATCH] powerpc: Fix initialization and usage of dma_mask Benjamin Herrenschmidt
2007-08-06 22:30 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B7A22D.4030909@shaw.ca \
--to=hancockr@shaw.ca \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=olh@suse.de \
--cc=stable@kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).