From: Scott Wood <scottwood@freescale.com>
To: Soohyung Cho <xfree@paran.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/4] mpc83xx: Power Management support
Date: Fri, 10 Aug 2007 09:47:24 -0500 [thread overview]
Message-ID: <46BC7A7C.6000409@freescale.com> (raw)
In-Reply-To: <1186728172263333.40.nmailpop03@nmailpop03>
Soohyung Cho wrote:
>>+void fsl_sleep_device(struct fsl_sleep_platform_data *data) {
>>+ if (clock_regs && data->sccr_mask) {
>>+ unsigned long flags;
>>+ u32 sccr;
>
>
> Your && operation between clock_regs and sccr_mask seems to be a little bit
> mistake,
> cause type is different.
Hmm? It's logical AND, not binary. There's no need for the types to be
the same.
> (clock->regs->sccr && data->sccr_mask) looks fine.
Except that that would be wrong. I'm checking to make sure that the
registers were found, not anything about the contents of the register.
-Scott
next parent reply other threads:[~2007-08-10 14:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1186728172263333.40.nmailpop03@nmailpop03>
2007-08-10 14:47 ` Scott Wood [this message]
2007-07-12 19:17 [PATCH 0/4] 83xx Power Management Scott Wood
2007-07-12 19:18 ` [PATCH 2/4] mpc83xx: Power Management support Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46BC7A7C.6000409@freescale.com \
--to=scottwood@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=xfree@paran.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).