From: Timur Tabi <timur@freescale.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH v2] powerpc: add setmaskedbits macros
Date: Thu, 16 Aug 2007 12:45:55 -0500 [thread overview]
Message-ID: <46C48D53.1050208@freescale.com> (raw)
In-Reply-To: <1187282419.30809.35.camel@localhost.localdomain>
Benjamin Herrenschmidt wrote:
>> The second example is actually a trick that lets me set some bits and clear
>> others in one shot, so for the gumr_h register, all of the above values are
>> single bits. I guess that's not a good example.
>
> Such tricks deserve at least a comment.
Would it be better if the function were called setclrbits_xxx(), and advertise
that it can be used to set multi-bit fields *and* set and clear bits at the
same time?
--
Timur Tabi
Linux Kernel Developer @ Freescale
next prev parent reply other threads:[~2007-08-16 17:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-15 21:30 [PATCH v2] powerpc: add setmaskedbits macros Timur Tabi
2007-08-16 3:22 ` Kumar Gala
2007-08-16 15:18 ` Timur Tabi
2007-08-16 15:21 ` Kumar Gala
2007-08-16 15:26 ` Timur Tabi
2007-08-16 16:40 ` Benjamin Herrenschmidt
2007-08-16 17:45 ` Timur Tabi [this message]
2007-08-16 3:55 ` Michael Ellerman
2007-08-16 7:19 ` Geert Uytterhoeven
2007-08-16 15:27 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C48D53.1050208@freescale.com \
--to=timur@freescale.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).