From: Scott Wood <scottwood@freescale.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH 05/20] bootwrapper: flatdevtree fixes
Date: Tue, 21 Aug 2007 11:09:58 -0500 [thread overview]
Message-ID: <46CB0E56.2020601@freescale.com> (raw)
In-Reply-To: <20070821023044.GF15469@localhost.localdomain>
David Gibson wrote:
> On Mon, Aug 20, 2007 at 12:39:49PM -0500, Scott Wood wrote:
>
>>1. ft_create_node was returning the internal pointer rather than a phandle.
>>2. ft_find_device_rel was treating a "top" phandle of NULL as an error,
>>rather than as the root of the tree.
>>3. Return the node's name when getprop() is called with the "name"
>>property.
>
>
> Hrm. I'm not convinced. (1) certainly needs fixing. (2) is kind of
> unclear - there is an ft_find_device() after all for doing root-based
> searches.
The point of #2 was as part of the fix to #1 -- otherwise, the same
check for NULL would have to be moved into ft_create_node to
conditionally call ft_find_device or ft_find_device_rel.
The non-relative function should probably be removed, though.
> (3) I really dislike; I just don't see the point.
It's needed by dt_get_path().
-Scott
next prev parent reply other threads:[~2007-08-21 16:09 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-20 17:39 [PATCH 01/20] bootwrapper: Update .gitignore Scott Wood
2007-08-20 17:39 ` [PATCH 02/20] bootwrapper: Set timebase_period_ns from dt_fixup_cpu_clocks Scott Wood
2007-08-21 1:53 ` David Gibson
2007-08-20 17:39 ` [PATCH 03/20] bootwrapper: dt_xlate_range() bugfixes Scott Wood
2007-08-21 2:01 ` David Gibson
2007-08-20 17:39 ` [PATCH 04/20] bootwrapper: Add dt_is_compatible() Scott Wood
2007-08-21 2:28 ` David Gibson
2007-08-20 17:39 ` [PATCH 05/20] bootwrapper: flatdevtree fixes Scott Wood
2007-08-21 2:30 ` David Gibson
2007-08-21 16:09 ` Scott Wood [this message]
2007-08-22 1:09 ` David Gibson
2007-08-22 17:24 ` Scott Wood
2007-08-23 2:01 ` David Gibson
2007-08-23 17:48 ` Scott Wood
2007-08-24 1:01 ` David Gibson
2007-08-24 14:48 ` Scott Wood
2007-08-24 22:17 ` David Gibson
2007-08-23 18:00 ` Segher Boessenkool
2007-08-20 17:39 ` [PATCH 06/20] bootwrapper: Add 16-bit I/O, sync(), eieio(), and barrier() Scott Wood
2007-08-21 2:31 ` David Gibson
2007-08-20 17:39 ` [PATCH 07/20] bootwrapper: Add TARGET_HAS_ETHn tests to ppcboot.h Scott Wood
2007-08-21 3:33 ` David Gibson
2007-08-20 17:39 ` [PATCH 08/20] bootwrapper: serial_console_init() fixes Scott Wood
2007-08-21 2:38 ` David Gibson
2007-08-20 17:39 ` [PATCH 09/20] bootwrapper: Declare udelay() in ops.h Scott Wood
2007-08-21 2:39 ` David Gibson
2007-08-21 16:12 ` Scott Wood
2007-08-22 1:09 ` David Gibson
2007-08-20 17:39 ` [PATCH 10/20] bootwrapper: Add CPM serial driver Scott Wood
2007-08-21 2:42 ` David Gibson
2007-08-21 16:15 ` Scott Wood
2007-08-22 1:10 ` David Gibson
2007-08-20 17:39 ` [PATCH 11/20] bootwrapper: Move linker symbols into ops.h Scott Wood
2007-08-21 2:43 ` David Gibson
2007-08-20 17:40 ` [PATCH 12/20] bootwrapper: Add 8xx cuboot support Scott Wood
2007-08-21 2:44 ` David Gibson
2007-08-21 16:20 ` Scott Wood
2007-08-22 1:47 ` David Gibson
2007-08-20 17:40 ` [PATCH 13/20] bootwrapper: Add PowerQUICC II (82xx with CPM) " Scott Wood
2007-08-21 3:30 ` David Gibson
2007-08-20 17:40 ` [PATCH 14/20] bootwrapper: Add strtoull() Scott Wood
2007-08-21 2:47 ` David Gibson
2007-08-21 16:20 ` Scott Wood
2007-08-20 17:40 ` [PATCH 15/20] bootwrapper: Add dt_get_path() Scott Wood
2007-08-21 3:03 ` David Gibson
2007-08-20 17:40 ` [PATCH 16/20] bootwrapper: Move strncmp() and strchr() from flatdevtree_env.h to string.h Scott Wood
2007-08-21 3:06 ` David Gibson
2007-08-20 17:40 ` [PATCH 17/20] bootwrapper: Add PlanetCore firmware support Scott Wood
2007-08-21 3:16 ` David Gibson
2007-08-21 16:29 ` Scott Wood
2007-08-22 1:20 ` David Gibson
2007-08-20 17:40 ` [PATCH 18/20] bootwrapper: Add a zImage.bin.<platform> target Scott Wood
2007-08-21 3:27 ` David Gibson
2007-08-20 17:40 ` [PATCH 19/20] bootwrapper: Only print MAC addresses when the node is actually present Scott Wood
2007-08-21 3:20 ` David Gibson
2007-08-20 17:40 ` [PATCH 20/20] bootwrapper: Add fsl_get_immr(), mpc885_get_clock(), and pq2_get_clocks() Scott Wood
2007-08-21 3:25 ` David Gibson
2007-08-21 16:34 ` Scott Wood
2007-08-22 1:30 ` David Gibson
2007-08-21 1:50 ` [PATCH 01/20] bootwrapper: Update .gitignore David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46CB0E56.2020601@freescale.com \
--to=scottwood@freescale.com \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).