From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <46CB1425.1040709@freescale.com> Date: Tue, 21 Aug 2007 11:34:45 -0500 From: Scott Wood MIME-Version: 1.0 To: David Gibson Subject: Re: [PATCH 20/20] bootwrapper: Add fsl_get_immr(), mpc885_get_clock(), and pq2_get_clocks(). References: <20070820173920.GA30546@ld0162-tx32.am.freescale.net> <20070820174013.GS30562@ld0162-tx32.am.freescale.net> <20070821032546.GS15469@localhost.localdomain> In-Reply-To: <20070821032546.GS15469@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Cc: linuxppc-dev@ozlabs.org, paulus@samba.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , David Gibson wrote: > On Mon, Aug 20, 2007 at 12:40:13PM -0500, Scott Wood wrote: > >>fsl_get_immr() is equivalent to the kernel's get_immrbase() function. > > I notice that this function assumes that P==V. Is that true for all > relevant platforms at this point? Yes. If that ever changes, we'd probably need to add a virtual-immr or similar. >>mpc885_get_clock() transforms a crystal frequency into a system frequency >>according to the PLL register settings. >> >>pq2_get_clocks() does the same as the above for the PowerQUICC II, >>except that it produces several different clocks. > > I'd prefer if these functions worked analagously to the > ibm440gp_fixup_clocks() function in ebony.c and fixed up the clock > values in the device tree directly, rather than returning them (where > the caller will presumably poke them into the device tree). I wanted to separate the register interpretation from the knowledge of where things are in the device tree. -Scott