From: Scott Wood <scottwood@freescale.com>
To: Vitaly Bordug <vitb@kernel.crashing.org>
Cc: netdev@vger.kernel.org, jgarzik@pobox.com, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 4/7] fs_enet: mac-fcc: Eliminate __fcc-* macros.
Date: Wed, 22 Aug 2007 16:17:01 -0500 [thread overview]
Message-ID: <46CCA7CD.3060109@freescale.com> (raw)
In-Reply-To: <20070823010826.6ae3452d@localhost.localdomain>
Vitaly Bordug wrote:
>>-#define W8(_p, _m, _v) __fcc_out8(&(_p)->_m, (_v))
>>-#define R8(_p, _m) __fcc_in8(&(_p)->_m)
>>+#define W8(_p, _m, _v) out_8(&(_p)->_m, (_v))
>>+#define R8(_p, _m) in_8(&(_p)->_m)
>> #define S8(_p, _m, _v) W8(_p, _m, R8(_p, _m) | (_v))
>> #define C8(_p, _m, _v) W8(_p, _m, R8(_p, _m) & ~(_v))
>>
>>@@ -290,7 +281,7 @@ static void restart(struct net_device *dev)
>>
>> /* clear everything (slow & steady does it) */
>> for (i = 0; i < sizeof(*ep); i++)
>>- __fcc_out8((char *)ep + i, 0);
>>+ out_8((char *)ep + i, 0);
>>
>
> Perhaps W8() here, to keep consistency?
W8 expects a struct pointer and member, which we don't have here.
-Scott
next prev parent reply other threads:[~2007-08-22 21:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-17 17:53 [PATCH 0/7] fs_enet patches Scott Wood
2007-08-17 17:53 ` [PATCH 1/7] Generic bitbanged MDIO library Scott Wood
2007-08-31 13:23 ` Jeff Garzik
2007-08-31 15:16 ` Scott Wood
2007-08-17 17:53 ` [PATCH 2/7] fs_enet: Whitespace cleanup Scott Wood
2007-08-22 21:04 ` Vitaly Bordug
2007-08-31 13:19 ` Jeff Garzik
2007-08-17 17:54 ` [PATCH 3/7] fs_enet: Don't share the interrupt Scott Wood
2007-08-17 17:54 ` [PATCH 4/7] fs_enet: mac-fcc: Eliminate __fcc-* macros Scott Wood
2007-08-22 21:08 ` Vitaly Bordug
2007-08-22 21:17 ` Scott Wood [this message]
2007-08-17 17:54 ` [PATCH 5/7] fs_enet: Align receive buffers Scott Wood
2007-08-17 17:54 ` [PATCH 6/7] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set Scott Wood
2007-08-17 17:54 ` [PATCH 7/7] fs_enet: sparse fixes Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46CCA7CD.3060109@freescale.com \
--to=scottwood@freescale.com \
--cc=jgarzik@pobox.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=vitb@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).