linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ppc32/8xx: Fix r3 trashing due to 8MB TLB page instantiation
@ 2007-08-28 11:20 Jochen Friedrich
  2007-08-29 12:22 ` Marcelo Tosatti
  2007-08-29 23:08 ` Kumar Gala
  0 siblings, 2 replies; 4+ messages in thread
From: Jochen Friedrich @ 2007-08-28 11:20 UTC (permalink / raw)
  To: linuxppc-embedded; +Cc: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 603 bytes --]

Instantiation of 8MB pages on the TLB cache for the kernel static
mapping trashes r3 register on !CONFIG_8xx_CPU6 configurations.
This ensures r3 gets saved and restored.

This has been posted to linuxppc-embedded by Marcelo Tosatti
<marcelo@kvack.org>, but only an incomplete version of the patch
has been applied in c51e078f82096a7d35ac8ec2416272e843a0e1c4.
This patch adds the rest of the fix.

Signed-off-by: Jochen Friedrich <jochen@scram.de>
---
 arch/ppc/kernel/head_8xx.S |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

This can be pulled from git://git.bocc.de/dbox2.git ppc-fixes

[-- Attachment #2: d14ebb1e9d133983252a14f2ef037f76969ab3c6.diff --]
[-- Type: text/x-patch, Size: 362 bytes --]

diff --git a/arch/ppc/kernel/head_8xx.S b/arch/ppc/kernel/head_8xx.S
index 944c35c..eb8d26f 100644
--- a/arch/ppc/kernel/head_8xx.S
+++ b/arch/ppc/kernel/head_8xx.S
@@ -495,9 +495,7 @@ LoadLargeDTLB:
 	lwz	r11, 4(r0)
 
 	lwz	r12, 16(r0)
-#ifdef CONFIG_8xx_CPU6
 	lwz	r3, 8(r0)
-#endif
 	rfi
 
 /* This is the data TLB error on the MPC8xx.  This could be due to


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-08-30  8:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-28 11:20 [PATCH] ppc32/8xx: Fix r3 trashing due to 8MB TLB page instantiation Jochen Friedrich
2007-08-29 12:22 ` Marcelo Tosatti
2007-08-29 23:08 ` Kumar Gala
2007-08-30  8:48   ` Jochen Friedrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).