From: Scott Wood <scottwood@freescale.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/3] Implement arch disable/enable irq hooks.
Date: Tue, 11 Sep 2007 16:33:05 -0500 [thread overview]
Message-ID: <46E70991.3060208@freescale.com> (raw)
In-Reply-To: <18151.1452.702936.394284@cargo.ozlabs.ibm.com>
Paul Mackerras wrote:
> It might be better to use hard_irq_disable rather than
> local_irq_disable here, since I think we will need that on 64-bit (and
> on 32-bit if we ever do lazy irq disabling there).
OK.
>> +/* Overrides the weak version in kernel/power/main.c */
>> +void arch_suspend_disable_irqs(void)
>> +{
>> + if (ppc_md.suspend_disable_irqs)
>> + ppc_md.suspend_disable_irqs();
>> + else
>> + generic_suspend_disable_irqs();
>
> Any particular reason why we need a ppc_md hook here? Do we expect
> some platform to need to do something different?
Not that I know the details of, but others requested it.
-Scott
next prev parent reply other threads:[~2007-09-11 21:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-05 22:06 [PATCH 1/3] Implement arch disable/enable irq hooks Scott Wood
2007-09-11 21:16 ` Paul Mackerras
2007-09-11 21:33 ` Scott Wood [this message]
2007-09-12 8:23 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46E70991.3060208@freescale.com \
--to=scottwood@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).