linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: rheap-managed bootmem allocator
Date: Wed, 19 Sep 2007 15:16:41 -0500	[thread overview]
Message-ID: <46F183A9.4060500@freescale.com> (raw)
In-Reply-To: <7307F27A-9C96-464A-9285-55DAB9A9A89D@kernel.crashing.org>

Kumar Gala wrote:

> seems like we should have a way to set bootmem_size via board/platform 
> code and not require a cmdline arg.

I can add a Kconfig option for it, but since there is no Kconfig for the rheap 
itself, I didn't know where to put it.  Once Sylvain's patch is accepted, I 
can update this patch by adding this Kconfig option:

config PPC_RHEAP_BOOTMEM
	int "Default size (in KB) of the rheap bootmem allocator"
	default 0
	---help---
	  This is the default size (in KB) of the boot memory to allocate (via
	  alloc_bootmem).  This value can be  overridden on the kernel command
	  line using the "rhbootmem" option (e.g. "rhbootmem=2M")

One thing I don't like, however, is the name.  It doesn't really make sense to 
call it the "rheap bootmem allocator" because the fact that it uses an rheap 
is hidden from the callers of rheap_bootmem_alloc().

-- 
Timur Tabi
Linux Kernel Developer @ Freescale

      reply	other threads:[~2007-09-19 20:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-19 19:15 [PATCH] powerpc: rheap-managed bootmem allocator Timur Tabi
2007-09-19 20:12 ` Kumar Gala
2007-09-19 20:16   ` Timur Tabi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46F183A9.4060500@freescale.com \
    --to=timur@freescale.com \
    --cc=galak@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).