* [PATCH] powerpc/configs: Disable /dev/port in skiroot defconfig
@ 2019-06-27 5:30 Daniel Axtens
2019-06-28 1:45 ` Michael Ellerman
2019-08-28 4:24 ` Michael Ellerman
0 siblings, 2 replies; 4+ messages in thread
From: Daniel Axtens @ 2019-06-27 5:30 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Daniel Axtens
While reviewing lockdown patches, I discovered that we still enable
/dev/port (CONFIG_DEVPORT) in skiroot.
We don't need it. Deselect CONFIG_DEVPORT for skiroot.
Signed-off-by: Daniel Axtens <dja@axtens.net>
---
arch/powerpc/configs/skiroot_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/configs/skiroot_defconfig b/arch/powerpc/configs/skiroot_defconfig
index 5ba131c30f6b..b2e8f37156eb 100644
--- a/arch/powerpc/configs/skiroot_defconfig
+++ b/arch/powerpc/configs/skiroot_defconfig
@@ -212,6 +212,7 @@ CONFIG_IPMI_WATCHDOG=y
CONFIG_HW_RANDOM=y
CONFIG_TCG_TPM=y
CONFIG_TCG_TIS_I2C_NUVOTON=y
+# CONFIG_DEVPORT is not set
CONFIG_I2C=y
# CONFIG_I2C_COMPAT is not set
CONFIG_I2C_CHARDEV=y
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/configs: Disable /dev/port in skiroot defconfig
2019-06-27 5:30 [PATCH] powerpc/configs: Disable /dev/port in skiroot defconfig Daniel Axtens
@ 2019-06-28 1:45 ` Michael Ellerman
2019-07-02 6:41 ` Daniel Axtens
2019-08-28 4:24 ` Michael Ellerman
1 sibling, 1 reply; 4+ messages in thread
From: Michael Ellerman @ 2019-06-28 1:45 UTC (permalink / raw)
To: Daniel Axtens, linuxppc-dev; +Cc: Daniel Axtens
Daniel Axtens <dja@axtens.net> writes:
> While reviewing lockdown patches, I discovered that we still enable
> /dev/port (CONFIG_DEVPORT) in skiroot.
>
> We don't need it. Deselect CONFIG_DEVPORT for skiroot.
Why don't we need it? :)
cheers
> diff --git a/arch/powerpc/configs/skiroot_defconfig b/arch/powerpc/configs/skiroot_defconfig
> index 5ba131c30f6b..b2e8f37156eb 100644
> --- a/arch/powerpc/configs/skiroot_defconfig
> +++ b/arch/powerpc/configs/skiroot_defconfig
> @@ -212,6 +212,7 @@ CONFIG_IPMI_WATCHDOG=y
> CONFIG_HW_RANDOM=y
> CONFIG_TCG_TPM=y
> CONFIG_TCG_TIS_I2C_NUVOTON=y
> +# CONFIG_DEVPORT is not set
> CONFIG_I2C=y
> # CONFIG_I2C_COMPAT is not set
> CONFIG_I2C_CHARDEV=y
> --
> 2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/configs: Disable /dev/port in skiroot defconfig
2019-06-28 1:45 ` Michael Ellerman
@ 2019-07-02 6:41 ` Daniel Axtens
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Axtens @ 2019-07-02 6:41 UTC (permalink / raw)
To: Michael Ellerman, linuxppc-dev
Michael Ellerman <mpe@ellerman.id.au> writes:
> Daniel Axtens <dja@axtens.net> writes:
>> While reviewing lockdown patches, I discovered that we still enable
>> /dev/port (CONFIG_DEVPORT) in skiroot.
>>
>> We don't need it. Deselect CONFIG_DEVPORT for skiroot.
>
> Why don't we need it? :)
I should have explained this better :)
/dev/port is used for old x86 style IO accesses.
It's set up in drivers/char/mem.c, and is only created if
arch_has_dev_port() returns true. Per arch/powerpc/include/asm/io.h, on
PPC64 with PCI, this is only true if there's a legacy ISA bridge.
Even if a system has a legacy ISA bridge installed, we have no business
accessing it in skiroot.
Regards,
Daniel
>
> cheers
>
>> diff --git a/arch/powerpc/configs/skiroot_defconfig b/arch/powerpc/configs/skiroot_defconfig
>> index 5ba131c30f6b..b2e8f37156eb 100644
>> --- a/arch/powerpc/configs/skiroot_defconfig
>> +++ b/arch/powerpc/configs/skiroot_defconfig
>> @@ -212,6 +212,7 @@ CONFIG_IPMI_WATCHDOG=y
>> CONFIG_HW_RANDOM=y
>> CONFIG_TCG_TPM=y
>> CONFIG_TCG_TIS_I2C_NUVOTON=y
>> +# CONFIG_DEVPORT is not set
>> CONFIG_I2C=y
>> # CONFIG_I2C_COMPAT is not set
>> CONFIG_I2C_CHARDEV=y
>> --
>> 2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/configs: Disable /dev/port in skiroot defconfig
2019-06-27 5:30 [PATCH] powerpc/configs: Disable /dev/port in skiroot defconfig Daniel Axtens
2019-06-28 1:45 ` Michael Ellerman
@ 2019-08-28 4:24 ` Michael Ellerman
1 sibling, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2019-08-28 4:24 UTC (permalink / raw)
To: Daniel Axtens, linuxppc-dev; +Cc: Daniel Axtens
On Thu, 2019-06-27 at 05:30:08 UTC, Daniel Axtens wrote:
> While reviewing lockdown patches, I discovered that we still enable
> /dev/port (CONFIG_DEVPORT) in skiroot.
>
> We don't need it. Deselect CONFIG_DEVPORT for skiroot.
>
> Signed-off-by: Daniel Axtens <dja@axtens.net>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/7e04a46d84f73ef0f21d2257d6ba2a194c0f1511
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-28 4:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-27 5:30 [PATCH] powerpc/configs: Disable /dev/port in skiroot defconfig Daniel Axtens
2019-06-28 1:45 ` Michael Ellerman
2019-07-02 6:41 ` Daniel Axtens
2019-08-28 4:24 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).