From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E44DBC3A5A6 for ; Thu, 19 Sep 2019 10:36:04 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9AEA32053B for ; Thu, 19 Sep 2019 10:36:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9AEA32053B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46YtYG0JtpzF4gS for ; Thu, 19 Sep 2019 20:36:02 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46YtKK5f7tzF4XJ for ; Thu, 19 Sep 2019 20:25:41 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: by ozlabs.org (Postfix, from userid 1034) id 46YtKK3P26z9sP6; Thu, 19 Sep 2019 20:25:41 +1000 (AEST) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 41ba17f20ea835c489e77bd54e2da73184e22060 In-Reply-To: <20190827101635.6942-1-maddy@linux.vnet.ibm.com> To: Madhavan Srinivasan From: Michael Ellerman Subject: Re: [PATCH v3] powerpc/imc: Dont create debugfs files for cpu-less nodes Message-Id: <46YtKK3P26z9sP6@ozlabs.org> Date: Thu, 19 Sep 2019 20:25:41 +1000 (AEST) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, Madhavan Srinivasan , Qian Cai Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, 2019-08-27 at 10:16:35 UTC, Madhavan Srinivasan wrote: > Commit <684d984038aa> ('powerpc/powernv: Add debugfs interface for imc-mode > and imc') added debugfs interface for the nest imc pmu devices to support > changing of different ucode modes. Primarily adding this capability for > debug. But when doing so, the code did not consider the case of cpu-less > nodes. So when reading the _cmd_ or _mode_ file of a cpu-less node > will create this crash. > ... > > Fixes: 684d984038aa ('powerpc/powernv: Add debugfs interface for imc-mode and imc') > Reported-by: Qian Cai > Suggested-by: Michael Ellerman > Signed-off-by: Madhavan Srinivasan Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/41ba17f20ea835c489e77bd54e2da73184e22060 cheers