From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Ganesh Goudar <ganeshgr@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org
Cc: mahesh@linux.vnet.ibm.com, npiggin@gmail.com
Subject: Re: [PATCH v2] powerpc: dump kernel log before carrying out fadump or kdump
Date: Thu, 19 Sep 2019 20:25:48 +1000 (AEST) [thread overview]
Message-ID: <46YtKT1sSHz9sPf@ozlabs.org> (raw)
In-Reply-To: <20190904075949.15607-1-ganeshgr@linux.ibm.com>
On Wed, 2019-09-04 at 07:59:49 UTC, Ganesh Goudar wrote:
> Since commit 4388c9b3a6ee ("powerpc: Do not send system reset request
> through the oops path"), pstore dmesg file is not updated when dump is
> triggered from HMC. This commit modified system reset (sreset) handler
> to invoke fadump or kdump (if configured), without pushing dmesg to
> pstore. This leaves pstore to have old dmesg data which won't be much
> of a help if kdump fails to capture the dump. This patch fixes that by
> calling kmsg_dump() before heading to fadump ot kdump.
>
> Fixes: 4388c9b3a6ee ("powerpc: Do not send system reset request through the oops path")
> Reviewed-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
> Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
> Signed-off-by: Ganesh Goudar <ganeshgr@linux.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/e7ca44ed3ba77fc26cf32650bb71584896662474
cheers
prev parent reply other threads:[~2019-09-19 10:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 7:59 [PATCH v2] powerpc: dump kernel log before carrying out fadump or kdump Ganesh Goudar
2019-09-19 10:25 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46YtKT1sSHz9sPf@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=ganeshgr@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).