From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ACF7C3A5A6 for ; Thu, 19 Sep 2019 10:47:20 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51225207FC for ; Thu, 19 Sep 2019 10:47:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51225207FC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46YtpF5k9DzF4tJ for ; Thu, 19 Sep 2019 20:47:17 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46YtKT5HX4zF4Xs for ; Thu, 19 Sep 2019 20:25:49 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: by ozlabs.org (Postfix, from userid 1034) id 46YtKT1sSHz9sPf; Thu, 19 Sep 2019 20:25:48 +1000 (AEST) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: e7ca44ed3ba77fc26cf32650bb71584896662474 In-Reply-To: <20190904075949.15607-1-ganeshgr@linux.ibm.com> To: Ganesh Goudar , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Subject: Re: [PATCH v2] powerpc: dump kernel log before carrying out fadump or kdump Message-Id: <46YtKT1sSHz9sPf@ozlabs.org> Date: Thu, 19 Sep 2019 20:25:48 +1000 (AEST) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mahesh@linux.vnet.ibm.com, npiggin@gmail.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, 2019-09-04 at 07:59:49 UTC, Ganesh Goudar wrote: > Since commit 4388c9b3a6ee ("powerpc: Do not send system reset request > through the oops path"), pstore dmesg file is not updated when dump is > triggered from HMC. This commit modified system reset (sreset) handler > to invoke fadump or kdump (if configured), without pushing dmesg to > pstore. This leaves pstore to have old dmesg data which won't be much > of a help if kdump fails to capture the dump. This patch fixes that by > calling kmsg_dump() before heading to fadump ot kdump. > > Fixes: 4388c9b3a6ee ("powerpc: Do not send system reset request through the oops path") > Reviewed-by: Mahesh Salgaonkar > Reviewed-by: Nicholas Piggin > Signed-off-by: Ganesh Goudar Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/e7ca44ed3ba77fc26cf32650bb71584896662474 cheers