From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <grygorii.strashko@ti.com>
Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.ozlabs.org (Postfix) with ESMTPS id 42H3xC4GvtzF3QR
 for <linuxppc-dev@lists.ozlabs.org>; Sat, 22 Sep 2018 05:45:50 +1000 (AEST)
Subject: Re: [PATCH net-next 00/22] net: fix return type of ndo_start_xmit
 function
To: YueHaibing <yuehaibing@huawei.com>, <davem@davemloft.net>,
 <dmitry.tarnyagin@lockless.no>, <wg@grandegger.com>,
 <mkl@pengutronix.de>, <michal.simek@xilinx.com>,
 <hsweeten@visionengravers.com>, <madalin.bucur@nxp.com>,
 <pantelis.antoniou@gmail.com>, <claudiu.manoil@nxp.com>,
 <leoyang.li@nxp.com>, <linux@armlinux.org.uk>, <sammy@sammy.net>,
 <ralf@linux-mips.org>, <nico@fluxnic.net>,
 <steve.glendinning@shawell.net>, <f.fainelli@gmail.com>,
 <w-kwok2@ti.com>, <m-karicheri2@ti.com>, <t.sailer@alumni.ethz.ch>,
 <jreuter@yaina.de>, <kys@microsoft.com>, <haiyangz@microsoft.com>,
 <wei.liu2@citrix.com>, <paul.durrant@citrix.com>,
 <arvid.brodin@alten.se>, <pshelar@ovn.org>
CC: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
 <linux-can@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
 <linuxppc-dev@lists.ozlabs.org>, <linux-mips@linux-mips.org>,
 <linux-omap@vger.kernel.org>, <linux-hams@vger.kernel.org>,
 <devel@linuxdriverproject.org>, <linux-usb@vger.kernel.org>,
 <xen-devel@lists.xenproject.org>, <dev@openvswitch.org>
References: <20180920123306.14772-1-yuehaibing@huawei.com>
From: Grygorii Strashko <grygorii.strashko@ti.com>
Message-ID: <46f95cf9-8f8f-e3ab-3142-947faeee9fa9@ti.com>
Date: Thu, 20 Sep 2018 12:04:58 -0500
MIME-Version: 1.0
In-Reply-To: <20180920123306.14772-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset="utf-8"
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/linuxppc-dev/>
List-Post: <mailto:linuxppc-dev@lists.ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>



On 09/20/2018 07:32 AM, YueHaibing wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, so make sure the implementation in
> this driver has returns 'netdev_tx_t' value, and change the function
> return type to netdev_tx_t.
> 

May be I missed smth, but it's acceptable to report standard error codes from
.xmit() callback as per dev_xmit_complete().

-- 
regards,
-grygorii